Skip to content

krr: 1.7.1 -> 1.28.0#502031

Open
JamieMagee wants to merge 2 commits into
NixOS:masterfrom
JamieMagee:krr-fix-327629
Open

krr: 1.7.1 -> 1.28.0#502031
JamieMagee wants to merge 2 commits into
NixOS:masterfrom
JamieMagee:krr-fix-327629

Conversation

@JamieMagee

@JamieMagee JamieMagee commented Mar 21, 2026

Copy link
Copy Markdown
Member

Update krr and its dependency prometrix to fix the build. krr has been broken since mid-2024 because prometrix was marked broken against prometheus-api-client >= 0.5.3 (nixpkgs has 0.7.0). Upstream fixed the incompatibility a while ago.

  • prometrix: 0.1.18-unstable-2024-04-30 -> 0.2.11-unstable-2026-03-11 (removes broken flag)
  • krr: 1.7.1 -> 1.28.0

The upstream tests use a deprecated click API (CliRunner(mix_stderr=False)) so they're disabled. pythonImportsCheck passes and krr version returns 1.28.0.

Fixes: #327629

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@JamieMagee JamieMagee mentioned this pull request Mar 21, 2026
Open
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 21, 2026
@JamieMagee

This comment was marked as outdated.

Sign in to view
dotlambda
dotlambda reviewed Mar 22, 2026
View reviewed changes

@dotlambda dotlambda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add an updateScript.

Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 22, 2026
@JamieMagee
JamieMagee requested a review from dotlambda March 22, 2026 06:00
dotlambda
dotlambda reviewed Mar 23, 2026
View reviewed changes
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
dotlambda
dotlambda reviewed Mar 23, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
@JamieMagee
JamieMagee force-pushed the krr-fix-327629 branch 3 times, most recently from 6e1c252 to 5c55a34 Compare March 23, 2026 19:50
@JamieMagee
JamieMagee requested a review from dotlambda March 23, 2026 19:50
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 23, 2026
@JamieMagee

This comment was marked as outdated.

Sign in to view
dotlambda
dotlambda reviewed Mar 23, 2026
View reviewed changes
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 29, 2026
@JamieMagee

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 26, 2026
@JamieMagee

JamieMagee commented May 11, 2026

Copy link
Copy Markdown
Member Author

@dotlambda I dropped the overrideScope entirely and applied robusta-dev/krr#512 as a patch instead, so the django and yarl workarounds are gone.

@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 11, 2026
@JamieMagee

This comment was marked as outdated.

Sign in to view
@JamieMagee

JamieMagee commented May 11, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 502031
Commit: 912ebcfa48f546a3569e56f526acb1c293ceb169 (subsequent changes)
Merge: 143a473bf994bd2c486f8a6a19dbc645ae1d111a

Logs: https://github.com/JamieMagee/nixpkgs-review-gha/actions/runs/25689613625

x86_64-linux

✅ 4 packages built:
  • krr
  • krr.dist
  • python313Packages.prometrix
  • python313Packages.prometrix.dist

aarch64-linux

✅ 4 packages built:
  • krr
  • krr.dist
  • python313Packages.prometrix
  • python313Packages.prometrix.dist

@JamieMagee
JamieMagee requested a review from dotlambda May 11, 2026 18:45
doronbehar
doronbehar reviewed Jul 10, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/prometrix/default.nix
# https://github.com/robusta-dev/prometrix/issues/19
rev = "35128847d46016b88455e0a98f0eeec08d042107";
hash = "sha256-g8ZqgL9ETVwpKLMQS7s7A4GpSGfaFEDLOr8JBvFl2C4=";
rev = "e84d6639226aea5f9ef1ea565d1932bf29807344";

@doronbehar doronbehar Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason now to use an unstable tag? A comment like that above upstream issue would be nice.

@JamieMagee JamieMagee Jul 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prometrix doesn't publish tags or releases.

@doronbehar doronbehar Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prometrix doesn't publish tags or releases.

Then please keep the link to the upstream issue. robusta-dev/prometrix#8 is a better link then robusta-dev/prometrix#19 .

Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
@JamieMagee
JamieMagee requested a review from doronbehar July 16, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda
@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: krr

3 participants

@JamieMagee @dotlambda @doronbehar