Skip to content

feat(slang): modifiers - #698

Draft
hedgar2017 wants to merge 1 commit into
az-slang-inheritancefrom
az-slang-modifiers
Draft

feat(slang): modifiers#698
hedgar2017 wants to merge 1 commit into
az-slang-inheritancefrom
az-slang-modifiers

Conversation

@hedgar2017

@hedgar2017 hedgar2017 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Lowers modifiers in the Slang frontend: modifier definitions, invocation regions evaluating their arguments, the placeholder, and Slang's answer for which modifier an entry runs when the compiled contract dispatches it.

cargo run-tester-slang: 18385 -> 18434 passed.

https://claude.ai/code/session_01U1vBrn8EeERepkVEG6CX46

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Coverage Summary

Crate Line Coverage Function Coverage
solx 🟢 83.6% 🔴 20.0%
solx-benchmark-converter 🔴 0.0% 🔴 0.0%
solx-codegen-evm 🔴 25.6% 🔴 13.4%
solx-compiler-downloader 🔴 0.0% 🔴 0.0%
solx-core 🔴 38.7% 🔴 48.0%
solx-dev 🔴 2.4% 🔴 3.0%
solx-evm-assembly 🔴 0.0% 🔴 0.0%
solx-mlir 🟡 50.4% 🔴 46.3%
solx-slang 🔴 21.4% 🔴 30.2%
solx-solc-test-adapter 🔴 1.7% 🔴 2.1%
solx-standard-json 🔴 42.8% 🔴 47.7%
solx-tester 🔴 36.2% 🔴 34.0%
solx-utils 🔴 29.0% 🔴 32.5%
solx-yul 🔴 0.0% 🔴 0.0%
Total 🔴 10.9% 🔴 13.2%

Codecov Report | HTML Report | Workflow Run

Lowers modifiers in the Slang frontend: a `sol.modifier` defined at the first invocation naming it, `sol.modifier_invocation` regions evaluating the arguments in each modified function's entry block after its base-constructor call, and `sol.placeholder` for `_`. Which modifier an entry runs is Slang's answer, so a bare name runs the modifier the compiled contract dispatches and a qualified one the declaration.

Claude-Session: https://claude.ai/code/session_01U1vBrn8EeERepkVEG6CX46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant