Export Siren's full typed taxonomy; wire mypy strict lint#3
Open
alexstandiford wants to merge 2 commits into
Open
Export Siren's full typed taxonomy; wire mypy strict lint#3alexstandiford wants to merge 2 commits into
alexstandiford wants to merge 2 commits into
Conversation
…lint Siren owns its domain vocabulary (global-taxonomy-and-sdk-doctrine); this SDK is the typed carrier of it so integrations never hand-roll magic strings. - Add EventSlug (built-in ingestion slugs) and status enums: ConversionStatus, TransactionStatus, ObligationStatus, PayoutStatus, FulfillmentStatus, OpportunityStatus, ApiKeyStatus, WebhookSubscriptionStatus (all str-valued, exported from the package root). - WebhookEventType: add CREDIT_ISSUED, CREDIT_REDEEMED, CURRENCY_CREATED, CURRENCY_DELETED — dispatched by the service but missing from the SDK and openapi.yaml. - Pin the canonical vocabularies in tests/test_taxonomy.py (mirrors the service's dispatchers and REST validations). - Wire mypy --strict as the repo lint (pyproject [tool.mypy], navigator.yaml ci.lint, CI lint job); fix the two findings it surfaced. Charter 761 (SDKs speak the taxonomy). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138jQKyzwyDfEbbAeMmYNnL
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138jQKyzwyDfEbbAeMmYNnL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Charter 761 (SDKs speak the taxonomy) — the SDK becomes the typed carrier of Siren's domain vocabulary so integrations reach for SDK enums instead of magic strings (doctrine:
global-taxonomy-and-sdk-doctrine).Typed taxonomy
siren.types, exported from the package root (same pattern asWebhookEventType):EventSlug(built-in ingestion slugssale/refund/site-visited),ConversionStatus,TransactionStatus,ObligationStatus,PayoutStatus,FulfillmentStatus,OpportunityStatus,ApiKeyStatus,WebhookSubscriptionStatus.WebhookEventType: 4 missing events added —CREDIT_ISSUED,CREDIT_REDEEMED,CURRENCY_CREATED,CURRENCY_DELETED. The Siren service registers dispatchers for all four but the SDK andopenapi.yamlnever listed them. Both updated.tests/test_taxonomy.pypins every vocabulary to the canonical set mined from the service (webhook dispatchers + REST validations). Stale 28-count assertion intest_webhooks.pyupdated to 32.Linter wiring (repo-agent-readiness-standard)
ci.lint. Wiredmypy --strictoversrc/siren([tool.mypy]in pyproject,mypy>=1.8in dev extras), declared asci.lintinnavigator.yaml, enforced by a new CI lint job. Mirrors siren-node's typecheck-as-lint contract.Anyreturn in backoff-delay, an unparameterizeddictannotation — no behavior change).Source of truth
Vocabularies mined from
Novatorius/siren(the taxonomy owner). Noted upstream inconsistency (encoded as-is, flagged for founder): obligation machine paths writecompletewhile the management REST surface acceptsfulfilled— both included inObligationStatus.Verification
pytest: 90 tests green (was 78; +12 taxonomy pins)mypy(strict): no issues in 10 source files🤖 Generated with Claude Code
https://claude.ai/code/session_0138jQKyzwyDfEbbAeMmYNnL