fix: read sink state once per tick instead of three pactl calls per dial - #2
Merged
Merged
Conversation
|
🎉 This PR is included in version 0.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With dials on screen, the plugin spawned ~29
pactlprocesses per second continuously, loading pipewire-pulse.Cause
_tick_levelsruns at ~8 Hz and, for every encoder,_readcalledsink_exists(pactl list short sinks),get_volumeandget_mute— three subprocesses per dial per tick.Scope
owdeck/graph.py: replacesink_exists/get_volumewithsinks()— onepactl -f json list sinksreturning{name: (volume, muted)}; failure or bad output returns{}(mix shows unavailable, as before).plugin.py:_sink_states()caches that map forSNAPSHOT_SECONDS(0.9 s), shared by all dials; invalidated after our ownset_volume/toggle_muteand on OpenWave pushes, so user turns stay immediate and external changes show within ~1 s.tests/test_plugin.py: fixture stubsgraph.sinks; newTestSinkPollingbounds pactl spawns across many ticks with multiple dials.Verification
make test: 121 tests OK; the bound test fails (108 spawns vs limit 4) with the cache disabled.make validateclean.