[19.0][FIX] website_event_filter_city: freeze_time test to avoid event not showing once that date passes. - #551
Conversation
|
Hi @pilarvargas-tecnativa, |
|
You may hardcode dates, but if you use |
a2dc270 to
207e32a
Compare
I can not assure that will not happen, should not be the case. Anyway I took |
|
It seems to not work, as the test is frozen. |
…showing once that date passes.
207e32a to
fd95a3f
Compare
|
So finally is not possible to use |
59243b6 to
0d1007f
Compare
|
It pass on local environment, but neither pass OCA CI o our CI. It should be possible to use it as tour goes through but it never terminates the chrome. So rollback to first option as is the way odoo manage that case https://github.com/odoo/odoo/blob/47bf5e2e5e91cfbebd30ee83fc92441d551001d3/addons/website_event/tests/test_website_event.py#L59-L66. |
pedrobaeza
left a comment
There was a problem hiding this comment.
OK, let's continue that way.
/ocabot merge patch
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at be2fe6c. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa
ping @pedrobaeza @adasatorres-tecnativa
Tours were failing due to
date_endbeing hardcoded (2026-09-15), so it no longer appears on /event once that datepasses. Use dates relative to
fields.Datetime.now()instead.