Skip to content

Allow 'migrations' folder as subfolder of sql, not sql/sql_server #38

Description

@schuemie

In recent versions of SqlRender it is allowed to put your OhdsiSql in the inst/sql folder instead of the inst/sql/sql_server folder, and loadRenderTranslateSql() will still work. The main reasons are

  1. Techincally, it's OhdsiSql, not SQL Server SQL,
  2. Looks prettier.
  3. SqlRender has proven to be very capable of handling cross-platform idiosyncrasies, so most (if not all) packages have no need for platform-specific SQL.

(Note that plafform-specific code can still be placed in the appropriately named subfolders. It is just that 99.9% of SQL is OhdsiSql, so why not put it up a level?)

Currently ResultModelManager throw an error if I put the 'migrations' folder in the 'sql' folder. A simple extra lookup when looking for migration SQL would solve this. Could this be added?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions