fix(android): reject self-provider picker roots by veryCrunchy · Pull Request #446 · Obiente/native

veryCrunchy · 2026-09-05T15:22:11Z

Summary

Reject the app’s own DocumentsProvider authority from upload and folder-sync pickers.
Handle document, tree, percent-encoded, mixed-case, and Android user-prefixed authority forms.
Reject restored self-provider roots before any WebDAV cleanup, construction, or remote scan.
Reconcile legacy owned downloads through a journal-scoped cleanup path so pair and account removal can still complete.

Validation

Full repository checks passed.
Build host: eight focused Android picker, provider, capability, file-sync, and recovery test classes passed.
Build host: :androidApp:assembleDebug passed.
Exact validated code tree: 96c4e76e3efafc7198ed2b2948411ce1c08dfda5.

obiente-cloud · 2026-09-05T15:22:15Z

Obiente preview

NC Native · 62a3f5b86855 · Ready

Open preview

View in Obiente

_{Obiente updates this comment as the preview changes.}

chatgpt-codex-connector · 2026-09-05T15:23:48Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-06T07:24:32.224313Z	`62a3f5b`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 538e12112f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72c0b6edf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e91eb6921

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5bcc25f9d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d50a4e9048

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 156ee6febf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62a3f5b868

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-06T07:24:30Z

+    ).map { candidate ->
+        candidate to DocumentsContract.buildDocumentUriUsingTree(treeUri, candidate.documentId)
+    }
+    val hasRelevantPendingRecovery = indexedOwnership::hasPendingTransactions


Limit legacy recovery completion to the selected tree

When an upgraded installation has a pending ownership row for a different SAF tree or account in the legacy shared directory, indexedOwnership includes that row and this predicate remains true even after every candidate under the current self-provider root has been reconciled. Since recorded candidates and discovery are correctly limited to the current root, they can never remove the unrelated row, so pair and account removal remain blocked until an unrelated sync happens to recover. Restrict completion to rows attributable to this tree while retaining genuinely unclassified rows fail-closed.

AGENTS.md reference: AGENTS.md:L410-L411

Useful? React with 👍 / 👎.

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 15:22 Destroyed

veryCrunchy marked this pull request as ready for review September 5, 2026 15:23

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 15:23 Destroyed

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidMediaStoreSyncLocalTree.kt Outdated

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidMediaStoreSyncLocalTree.kt Outdated

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 16:01 Destroyed

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch from 7dfaeb8 to d963ee4 Compare September 5, 2026 22:42

veryCrunchy force-pushed the fix/picker-provider-feedback branch from 72c0b6e to 548a50d Compare September 5, 2026 22:44

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 22:44 Destroyed

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch from d963ee4 to b2c2188 Compare September 5, 2026 23:01

veryCrunchy force-pushed the fix/picker-provider-feedback branch from 548a50d to 8bacb4d Compare September 5, 2026 23:02

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 23:02 Destroyed

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 23:22 Destroyed

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidAccountRemoval.kt

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 5, 2026 23:56 Destroyed

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidAccountRemoval.kt

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch 3 times, most recently from 6057f39 to a712498 Compare September 6, 2026 04:47

veryCrunchy force-pushed the fix/picker-provider-feedback branch from 5bcc25f to d50a4e9 Compare September 6, 2026 04:48

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 6, 2026 04:48 Destroyed

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidFileSyncEngine.kt Outdated

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidAccountRemoval.kt Outdated

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch 3 times, most recently from cc5f869 to 337b65f Compare September 6, 2026 05:49

veryCrunchy force-pushed the fix/picker-provider-feedback branch from d50a4e9 to 156ee6f Compare September 6, 2026 05:50

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #446 / NC Native September 6, 2026 05:50 Destroyed

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidAccountCredentialController.kt Outdated

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/AndroidSafOwnedDownloadRetirement.kt Outdated

veryCrunchy and others added 8 commits September 6, 2026 09:13

fix(uploads): defer capability metadata read failures

189b141

fix(uploads): reject malformed capability metadata

d242a4f

fix(uploads): isolate malformed picker capabilities

e1dcf04

fix(uploads): protect owned malformed capabilities

1f795c9

test(uploads): split account resolution coverage

a2f1171

fix(uploads): reject corrupt capability ciphertext

c52b7a4

refactor(platform): preserve service size boundary

85e0a5b

chore(website): refresh marketing captures

30d6eb1

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch from 54c77f1 to 30d6eb1 Compare September 6, 2026 07:14

veryCrunchy added 12 commits September 6, 2026 09:14

fix(android): reject self-provider picker roots

14c8e5e

chore(changelog): record picker provider guard

05de16f

fix(android): preflight self-provider sync roots

b1b36bb

fix(android): recover legacy picker roots safely

02d11b3

fix(android): prepare account removal before lease

322ff79

fix(android): bind provider recovery to removed account

0d0e3ac

refactor(android): split picker persistence helpers

7cb9d7a

fix(android): retain unclassified download recovery

d8c705e

fix(android): revalidate account removal under lease

c8dc5cd

fix(android): harden legacy provider retirement

2a3ee73

fix(android): recover moved provider directories

8088f03

refactor(android): preserve sync engine boundary

62a3f5b

veryCrunchy force-pushed the fix/picker-provider-feedback branch from d897701 to 62a3f5b Compare September 6, 2026 07:16

obiente-cloud Bot deployed to Obiente Preview / PR #446 / NC Native September 6, 2026 07:16 View deployment

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

veryCrunchy force-pushed the fix/durable-upload-scheduling-recovery-stack branch 6 times, most recently from bcae385 to 1caca52 Compare September 6, 2026 12:32

Uh oh!

Conversation

veryCrunchy commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

obiente-cloud Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Obiente preview

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

veryCrunchy commented Sep 5, 2026 •

edited

Loading

obiente-cloud Bot commented Sep 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 5, 2026 •

edited

Loading