feat(storefront): custom css themes#733
Open
OisinKyne wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(storefront): branding polish, docs + screenshots, inline-logo fix
Polish pass over the branding work: footer wording, documentation with real screenshots, and a genuine bug found while capturing them.
What's here
html/templaterejectsdata:URIs in URL contexts (renders the literal#ZgotmplZ), so every logo inlined viasell info set --logo-fileshowed as a broken image on 402 and landing pages. Fixed withstorefront.SafeAssetURL, which validates http(s)/data:imageforms and returnstemplate.URL; regression testTestPaymentRequiredHTML_InlineDataURILogo. Recorded as CLAUDE.md pitfall 21 (plus pitfall 20: template-exec errors silently fall back to JSON 402s).docs/images/gains four captures rendered through the real pipeline (402 renderer with fixture profiles; the actual Next.js storefront fed a fixture catalog; headless Chrome). README's branding section shows default-vs-branded storefront and 402 side by side with the full flag set;docs/guides/monetize-inference.mdgains §1.8 "Brand Your Storefront"; CLAUDE.md documents all identity flags, the single-sanitizer rule, and thedata-obolcontract; the obol-stack-dev skill's rebuild matrix gains aninternal/storefront/**row; the embeddedsub-agent-businessskill's branding nudge is updated.Companion changes land separately in the gitbook (
obol-stack/selling-services.md+ assets) and skills (run-obol-stack) repos.Testing
Full Go suite + storefront build green; the inline-logo regression test pins the
template.URLbypass; screenshots double as a visual review of the light/dark/obol themes.🤖 Generated with Claude Code