Stop storing npm registry URLs in sample lockfiles - #1529
Merged
Alex Jerabek (AlexJerabek) merged 1 commit intoAug 25, 2026
Merged
Conversation
- ✨ Added project-level npm settings to the seven affected samples. - 🧹 Regenerated their lockfiles without registry resolved URLs or metadata changes. -= Maarten =- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
There are a lot more lock files in this repo than those targeted here. Any reason it's just a subset? |
Contributor
Author
|
Alex Jerabek (@AlexJerabek) these were the only ones that had Azure Artifacts feeds embedded in them. |
Alex Jerabek (AlexJerabek)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Seven sample projects now set
omit-lockfile-registry-resolved=truein project-level.npmrcfiles. Their lockfiles no longer record registry tarball URLs. Lockfile version 3 and all dependency, integrity, and platform metadata are unchanged.Guidance
This PR targets the
mainbranch.Validation
I used npm 11.19.0 for all seven projects.
npm install --package-lock-only --ignore-scripts --no-audit --no-fund: passed, with a clean second regeneration in every projectnpm ci --ignore-scripts --no-audit --no-fund --loglevel=error: passed in every projectnpm config get omit-lockfile-registry-resolved:truein every project0resolvedentry count:0resolved: equalnode --check: 34 JavaScript files passed across the four JavaScript samplesoffice-addin-manifest --help: passed in each Blazor sampleRemote manifest validation was attempted for the local and production manifests in all three Blazor samples. The validation service could not be reached: