Release 1.0.4: GitVersion versioning, single-step publishing - #120
Merged
Merged
Conversation
- Derive the package version from git tags with GitVersion.MsBuild (GitVersion.yml, ManualDeployment), as in sharp-louis and notika-windows. release.yml no longer computes the version from the tag with a regex, and CI checks out full history because GitVersion needs tags and fails on shallow clones. - The release workflow now publishes without a manual approval step; the nuget environment keeps only its v* tag restriction. - Remove the SQLitePCLRaw.bundle_e_sqlite3 reference that a stale Dependabot PR re-added after 1.0.3. It pulled in a second native SQLite package (SQLite 3.53.4) whose e_sqlite3 files collide with the SourceGear.sqlite3 library that sqlite-net-pcl already brings. - CHANGELOG: 1.0.4 section and missing version links. - CLAUDE.md: dependency list and release process. Claude-Session: https://claude.ai/code/session_01XugGo6npZqDT15B3EcMkDk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 44 44
Lines 4874 4874
Branches 726 726
=======================================
Hits 3842 3842
Misses 775 775
Partials 257 257 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the 1.0.4 patch release and brings the release setup in line with sharp-louis and notika-windows.
Versioning via GitVersion
GitVersion.MsBuild(dev-only) plusGitVersion.yml, copied from sharp-louis:ManualDeploymentmode,v/Vtag prefix.release.ymlno longer has the "Resolve version from tag" step or any-p:Version; GitVersion resolves the version inside MSBuild.dotnet.ymlchecks out full history (fetch-depth: 0) on all three OSes, because GitVersion needs tags and fails on shallow clones.Single-step publishing
release.ymlcomments now describe the flow as fully automatic once the tag is pushed.nugetenvironment no longer has a required reviewer. Itsv*tag restriction is unchanged, and the environment must stay because the nuget.org trusted-publishing policy pins it.SQLite dependency cleanup
SQLitePCLRaw.bundle_e_sqlite3reference, but Dependabot PR Deps: Bump SQLitePCLRaw.bundle_e_sqlite3 from 3.0.2 to 3.0.3 #89 (opened before 1.0.3, merged after) re-added it, and Deps: Bump SQLitePCLRaw.bundle_e_sqlite3 from 3.0.3 to 3.0.5 #115 bumped it to 3.0.5.SQLite3.53.4. Itse_sqlite3.dll,libe_sqlite3.soandlibe_sqlite3.dylibhave the same names as the files inSourceGear.sqlite33.53.3, whichsqlite-net-pclalready brings. So which native library ended up in the output depended on build order.sqlite-net-pcl1.11.285,SQLitePCLRaw.core/provider.e_sqlite33.0.3,SourceGear.sqlite33.53.3.Docs
CHANGELOG.md:[1.0.4] - 2026-09-10with theSyncOptionsdefault fix (Fix flaky CI: default SyncOptions, pause test race, job timeout #119), dependency updates and the SQLite cleanup, plus the missing compare links.CLAUDE.md: updated dependency list and a short "Releasing" section.Verification
dotnet build: 0 warnings (warnings are errors in the library)dotnet format --verify-no-changes: cleandotnet test: 819 passed, 130 skipped (integration), 0 failede_sqlite3.dll, anddeps.jsonlists onlySourceGear.sqlite3v1.0.4tag (deleted afterwards, never pushed),dotnet packproducedOire.SharpSync.1.0.4.nupkgboth on master and from a detached HEAD, as in CI. sharp-louis, which uses the same config, has released v2.0.0 through v3.0.0 with matching package versions.After merge
Push an annotated
v1.0.4tag on the merge commit.release.ymlthen publishes to nuget.org and creates the GitHub release with no further confirmation, and nuget.org versions are immutable.https://claude.ai/code/session_01XugGo6npZqDT15B3EcMkDk