Fix flaky storage progress tests, bump AWSSDK.S3 to 4.0.103.4 - #126
Merged
Merged
Conversation
SSH.NET invokes the upload callback from multiple threads, FluentFTP's Progress<T> posts to the thread pool, and S3 multipart parts upload in parallel, so ProgressChanged can fire concurrently. Concurrent List<T>.Add occasionally left a null slot, failing SftpStorageTests.ProgressChanged_LargeFile_RaisesEvents. Collect events in a ConcurrentQueue instead. Also bump AWSSDK.S3 from 4.0.103.1 to 4.0.103.4 (supersedes #124).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 44 44
Lines 4874 4874
Branches 726 726
=======================================
Hits 3842 3842
Misses 775 775
Partials 257 257 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SftpStorageTests.ProgressChanged_LargeFile_RaisesEventsfailed intermittently on Ubuntu CI (Assert.All() Failure: 1 out of 480 items… Item: null). SSH.NET invokes the upload progress callback from multiple threads, and the test collected events in a plainList<T>, so concurrentAddcalls occasionally left anullslot. The SFTP, FTP (FluentFTP'sProgress<T>posts to the thread pool) and S3 (parallel multipart parts) progress tests now useConcurrentQueue<T>. WebDAV'sProgressStreamis sequential and is unchanged. Test-only change; no library code touched.Note
LocalStack is currently not starting in CI:
localstack/localstack:latestnow requiresLOCALSTACK_AUTH_TOKEN("License activation failed… No credentials were found"), so the S3 integration tests are skipped. Fixing that needs either the secret (as both an Actions and a Dependabot secret) or pinning an older LocalStack image; not addressed here.Test plan
dotnet build: 0 warnings, 0 errorsdotnet format --verify-no-changes: cleandotnet testlocally: 819 passed, 130 integration tests skipped