docs(compose): flag rag service's now-unused GITHUB_TOKEN args/secret - #67
Merged
Merged
Conversation
omnibioai-rag#25 moved the rag service's image build to resolve @man4ish/ui and omnibioai-iam-client from sibling directories in the monorepo build context, so GITHUB_TOKEN, RAGBIO_API_KEY (as a build arg), and the github_token secret are no longer consumed by the Dockerfile. Docker silently ignores the unused args and never reads the secret, so nothing is broken -- but this compose file is shared infrastructure, so leave the actual removal for a deliberate cleanup pass rather than an unsupervised edit here. Comment-only change. OmniBioAI/omnibioai-rag#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment-only change: adds a
TODOdirectly above theragservice'sbuild.argsandsecretsblock indocker-compose.yml.Why
omnibioai-rag#25
moved that service's image build to resolve
@man4ish/uiandomnibioai-iam-clientfrom sibling directories already present in themonorepo build context (
${MACHINE_DIR}), instead of GitHub. As aresult,
GITHUB_TOKEN,RAGBIO_API_KEY(as a build arg), and thegithub_tokensecret are no longer consumed by the Dockerfile.Nothing is broken by this today — Docker ignores unused build args and
never reads an unconsumed secret — but this is a real, live
inconsistency worth not losing track of.
Why comment-only, not a removal
This is shared infrastructure (
docker-compose.yml), so the actualremoval is left for a deliberate cleanup pass with its own review,
rather than folded into an unrelated PR. This TODO just makes sure
whoever does that pass has the full context (PR #25) without needing
to rediscover it.
RAGBIO_API_KEYin the service'senvironment:block (further down,not touched here) is unrelated — that's the running container's own
env var, not the build-time bake-in that was removed.