Skip to content

Add final newline to CONTRIBUTING.md and SECURITY.md - #195

Merged
petrsnd merged 1 commit into
OneIdentity:mainfrom
petrsnd:bugfix/editorconfig-final-newline
Sep 5, 2026
Merged

Add final newline to CONTRIBUTING.md and SECURITY.md#195
petrsnd merged 1 commit into
OneIdentity:mainfrom
petrsnd:bugfix/editorconfig-final-newline

Conversation

@DanPeterson

Copy link
Copy Markdown
Contributor

The mvn verify / pipeline build is failing on main with:

CONTRIBUTING.md@45,18: Insert lf - violates insert_final_newline
SECURITY.md@40,77: Insert lf - violates insert_final_newline

Both files were added without a trailing newline, which violates insert_final_newline = true in .editorconfig. The editorconfig-maven-plugin:check goal (bound into verify) fails the build.

This appends the missing final newline to each file. mvn editorconfig:check now passes cleanly.

Both files ended without a trailing newline, violating insert_final_newline in .editorconfig. The editorconfig-maven-plugin check fails the Maven build once these files are present alongside the rest of the tree, breaking the pipeline.
@DanPeterson
DanPeterson requested a review from a team as a code owner September 5, 2026 19:02
@petrsnd
petrsnd merged commit de1bc4a into OneIdentity:main Sep 5, 2026
4 checks passed
@petrsnd
petrsnd deleted the bugfix/editorconfig-final-newline branch September 5, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants