Fix broken Javadoc reference breaking release build - #196
Merged
petrsnd merged 1 commit intoSep 5, 2026
Conversation
The constructor Javadoc linked {@link #TLS_PROTOCOL}, which is not a member of this class, causing javadoc:jar to fail with 'reference not found' during the release/deploy build (mvn verify does not run javadoc:jar, so it passed there). Point the link at TlsConfiguration#resolveEnabledProtocolNames(), matching the existing reference elsewhere in this file.
petrsnd
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the release/deploy pipeline failure (build 386656) introduced by the TLS 1.3 PR (#190).
Problem:
SafeguardEventListenerconstructor Javadoc linked{@link #TLS_PROTOCOL}, but no such member exists on the class.javadoc:jar(run only by the release/deploy step, not bymvn verify) treats the unresolved reference as a harderror: reference not foundand fails the build.Fix: Point the link at
TlsConfiguration#resolveEnabledProtocolNames()— the method that actually governs the enabled TLS protocol set — matching the existing reference elsewhere in the same file.Verification:
mvn javadoc:jarnow succeeds locally (previously failed); producedsafeguardjava-8.4.0-SNAPSHOT-javadoc.jarwith zero errors. Grepped the SDK for other{@link #/{@link Tlsreferences — no other broken links.