Skip to content

Apply preprocessor options before toolchain setup - #539

Merged
brondani merged 1 commit into
mainfrom
apply-preprocessor-options-before
Sep 17, 2026
Merged

brondani merged 1 commit into
mainfrom
apply-preprocessor-options-before

Conversation

@brondani

@brondani brondani commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@brondani
brondani force-pushed the apply-preprocessor-options-before branch from c4727d6 to 9a3b401 Compare September 17, 2026 12:43
@qltysh

qltysh Bot commented Sep 17, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.6%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
pkg/maker/contextlists.go100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

  5 files   15 suites   7s ⏱️
118 tests 118 ✅ 0 💤 0 ❌
590 runs  587 ✅ 3 💤 0 ❌

Results for commit 9a3b401.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments were identified.

Pull request overview

Updates generated preprocessor options so they are available during toolchain and compiler setup.

Changes:

  • Reorders preprocessor option generation in contextlists.go.
  • Updates affected golden CMake outputs across test fixtures.
File summaries
File Summary
test/data/solutions/pre-include/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include-oot/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include-oot/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include-oot/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/pre-include-oot/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/linker-pre-processing/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/linker-pre-processing/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/linker-pre-processing/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/linker-pre-processing/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/link-lib/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/link-lib/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/library-rtos/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/library-rtos/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/library-rtos/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/library-rtos/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/language-scope/ref/project.IAR+ARMCM0/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/language-scope/ref/project.GCC+ARMCM0/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/language-scope/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/language-scope/ref/project.AC6+ARMCM0/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/include-define/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/include-define/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/include-define/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/include-define/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/executes/ref/project.Release+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-cpp/ref/project.IAR+ARMCM55/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/build-cpp/ref/project.GCC+ARMCM55/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/build-cpp/ref/project.CLANG+ARMCM55/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/build-cpp/ref/project.AC6+ARMCM55/CMakeLists.txt Updates C/CXX output ordering.
test/data/solutions/build-c/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-c/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-c/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-c/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-asm/ref/project.IAR+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-asm/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-asm/ref/project.CLANG+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/build-asm/ref/project.AC6+ARMCM0/CMakeLists.txt Updates expected output ordering.
test/data/solutions/blanks/ref/project X.AC6 X+ARMCM0 X/CMakeLists.txt Updates expected output ordering.
test/data/solutions/abstractions/ref/project.GCC+ARMCM0/CMakeLists.txt Updates expected output ordering.
pkg/maker/contextlists.go Moves preprocessor option generation before toolchain setup.
Review details
  • Files reviewed: 42/42 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@brondani
brondani marked this pull request as ready for review September 17, 2026 13:09
@brondani
brondani requested a review from soumeh01 September 17, 2026 13:10
@brondani
brondani merged commit 2c43615 into main Sep 17, 2026
38 of 39 checks passed
@brondani
brondani deleted the apply-preprocessor-options-before branch September 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants