Apply preprocessor options before toolchain setup - #539
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
c4727d6 to
9a3b401
Compare
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
Test Results 5 files 15 suites 7s ⏱️ Results for commit 9a3b401. |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were identified.
Pull request overview
Updates generated preprocessor options so they are available during toolchain and compiler setup.
Changes:
- Reorders preprocessor option generation in
contextlists.go. - Updates affected golden CMake outputs across test fixtures.
File summaries
| File | Summary |
|---|---|
test/data/solutions/pre-include/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include-oot/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include-oot/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include-oot/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/pre-include-oot/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/linker-pre-processing/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/linker-pre-processing/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/linker-pre-processing/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/linker-pre-processing/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/link-lib/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/link-lib/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/library-rtos/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/library-rtos/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/library-rtos/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/library-rtos/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/language-scope/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/language-scope/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/language-scope/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/language-scope/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/include-define/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/include-define/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/include-define/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/include-define/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/executes/ref/project.Release+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-cpp/ref/project.IAR+ARMCM55/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/build-cpp/ref/project.GCC+ARMCM55/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/build-cpp/ref/project.CLANG+ARMCM55/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/build-cpp/ref/project.AC6+ARMCM55/CMakeLists.txt |
Updates C/CXX output ordering. |
test/data/solutions/build-c/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-c/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-c/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-c/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-asm/ref/project.IAR+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-asm/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-asm/ref/project.CLANG+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/build-asm/ref/project.AC6+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/blanks/ref/project X.AC6 X+ARMCM0 X/CMakeLists.txt |
Updates expected output ordering. |
test/data/solutions/abstractions/ref/project.GCC+ARMCM0/CMakeLists.txt |
Updates expected output ordering. |
pkg/maker/contextlists.go |
Moves preprocessor option generation before toolchain setup. |
Review details
- Files reviewed: 42/42 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Fixes
Changes
Checklist