ci: correct the gate comment — backend-ci-gate is now required on main - #2269
Merged
Conversation
#2267 landed the job with a comment stating main had no required_status_checks object. That was true when written and false ~15 minutes later, once require_backend_ci_gate.sh --apply ran. Leaving it would be the same defect this repo keeps finding -- a document asserting a gate's state in the present tense without it being so. Records the enforce_admins=false caveat alongside it, and keeps the pointer to `gh api .../branches/main/protection` as the authority over the comment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Reviewed. This is a comment-only change to Verification
Feedback
No bugs, security, or performance concerns — this is exactly the kind of self-correcting documentation fix the repo's CLAUDE.md changelog/docs guidance encourages (keep docs current and pointer-based rather than letting them rot). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2267 landed the
gatejob carrying this comment:True when written, false about 15 minutes later once
require_backend_ci_gate.sh --applyran:Leaving it would be the same defect this repo keeps turning up — a comment asserting a gate's state in the present tense when it isn't so. Updated to state what is actually true, keep the
enforce_admins: falsecaveat next to it, and keepgh api .../branches/main/protectionas the authority over the comment.Incidentally, this PR is the end-to-end proof
It is the first PR to merge under the required check. If
backend-ci-gatereports and gates it normally, the whole mechanism is confirmed on the wire rather than by inference.For the record, applying the protection immediately flipped every open PR to
BLOCKED— including #2260, #2264 and #2265, which were atlinter=failure / pytest=skippedand therefore mergeable with a red linter until an hour ago. They need a merge frommainto pick up the check, and then a green linter to pass it.🤖 Generated with Claude Code