Skip to content

battery: Add get-bix and set-btp support - #94

Open
kurtjd wants to merge 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:add-get-bix-set-btp
Open

battery: Add get-bix and set-btp support#94
kurtjd wants to merge 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:add-get-bix-set-btp

Conversation

@kurtjd

@kurtjd kurtjd commented Sep 4, 2026

Copy link
Copy Markdown
Member

Need to support get-bix and set-btp since these are required by our EC test apps. Tested with the test-cli app within th WinVOS image running on QEMU.

Resolves #93

@kurtjd kurtjd self-assigned this Sep 4, 2026
Copilot AI lite review requested due to automatic review settings September 4, 2026 20:10
@kurtjd
kurtjd requested a review from a team as a code owner September 4, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Implements the required commands with explicit serialization/dispatch tests and a minimal relay-side buffer adjustment to support the larger response size.

Pull request overview

This PR adds the missing battery relay functionality required by the EC test apps by extending the Battery FFA service to support GetBix and SetBtp in addition to the existing GetBst path.

Changes:

  • Introduces a typed BatteryCommand enum and adds get_bix / set_btp relay methods with fixed-size decoding/encoding.
  • Extends the FFA direct-request handler to dispatch GetBix, GetBst, and SetBtp.
  • Adds wire-format compatibility tests for GetBix and SetBtp, and increases the EC relay RX packet buffer to accommodate larger replies.
File summaries
File Description
ec-service-lib/src/services/ec_relay.rs Enlarges the per-call RX packet buffer to handle larger framed responses (needed for BIX-sized payloads).
ec-service-lib/src/services/battery.rs Adds GetBix/SetBtp command support end-to-end (relay + FFA dispatch) with gate tests to lock the wire format.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

battery: Add get-bix and set-btp support

3 participants