[REBASE & FF]AdvLogger: Add Dynamic HW Port Error Level Filtering - #1763
Open
os-d wants to merge 2 commits into
Open
[REBASE & FF]AdvLogger: Add Dynamic HW Port Error Level Filtering#1763os-d wants to merge 2 commits into
os-d wants to merge 2 commits into
Conversation
Contributor
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/33894217197 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
reviewed
Sep 1, 2026
joschock
approved these changes
Sep 1, 2026
Javagedes
reviewed
Sep 1, 2026
Javagedes
approved these changes
Sep 1, 2026
makubacki
approved these changes
Sep 1, 2026
cfernald
reviewed
Sep 1, 2026
Contributor
Author
|
@cfernald @joschock @Javagedes I have updated this to just be the callback and leaving the SerialIO trait to be the hw port abstraction. If we want to revisit a write only trait for that, we can do that in a separate PR. Let me know your thoughts. |
Currently, the EDK2 defined log levels are only partially defined in Patina (but we must respect them for compat), internal to adv logger. This commit makes them publicly available in the SDK so that a future change can allow platforms to implement hw port traits that rely on debug level. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This adds partial responsibility of the C AdvLoggerHdwPortLib to Patina. That lib in the C code allows for abstracting the hw port logged to, which is already provided by the SerialIO interface in Patina. However, that lib also allows for dynamic hw port error level filtering, which Patina does not currently provide. This commit adds an optional callback for platforms to provide an opportunity to dynamically set the hw port error level. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds partial responsibility of the C AdvLoggerHdwPortLib to Patina. That lib in the C code allows for abstracting the hw port logged to, which is already provided by the SerialIO interface in Patina. However, that lib also allows for dynamic hw port error level filtering, which Patina does not currently provide.
This PR adds an optional callback for platforms to provide an opportunity to dynamically set the hw port error level.
This originally targeted the major branch in: #1759 but feedback there gave an approach to avoid a breaking change.
How This Was Tested
On a platform with the existing SerialIO initialization and another platform with a custom HW port trait.
Integration Instructions
This is not a breaking change, but platforms may now introduce a custom callback, e.g.