Skip to content

SDK: SerDe HOB: Implement Interval for FvHobSerDe - #1769

Open
vineelko wants to merge 1 commit into
OpenDevicePartnership:mainfrom
vineelko:users/vineelko/sdk_interval_fixup_0905
Open

SDK: SerDe HOB: Implement Interval for FvHobSerDe#1769
vineelko wants to merge 1 commit into
OpenDevicePartnership:mainfrom
vineelko:users/vineelko/sdk_interval_fixup_0905

Conversation

@vineelko

@vineelko vineelko commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

Adds an Interval implementation for FvHobSerDe so firmware volume
descriptors can be compared and merged. Generalizes Interval::contains,
overlaps, and adjacent to accept any Interval type instead of only
Self.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

cargo make all

Integration Instructions

NA: Not a breaking change because Self already implements T: Interval

Adds an Interval implementation for FvHobSerDe so firmware volume
descriptors can be compared and merged. Generalizes Interval::contains,
overlaps, and adjacent to accept any Interval type instead of only
Self.
@vineelko
vineelko requested review from makubacki and os-d September 5, 2026 07:26
@patina-automation

patina-automation Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

All QEMU validation jobs completed successfully.

Note: Q35 is only built on Windows hosts (QEMU boot is disabled due to a QEMU vfat issue).

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/33953135612

Boot Time to EFI Shell

Platform Elapsed
ArmVirt (Linux Host) 25.3s
Q35 (Linux Host) 28.7s

Dependencies

Repository Ref
patina 8cb3b08
patina-dxe-core-qemu f636dd8
patina-fw-patcher c28ab7d
patina-qemu firmware v4.0.5
patina-qemu build script a8b6551

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

@github-actions github-actions Bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact impact:testing Affects testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants