Fix PD CFU timeout recovery

[asasine]

Summary

• Publish INT_EVENT_1 bits into durable software state before awaiting the destructive INT_CLEAR_1 W1C write. Pending clear masks survive failure or cancellation, retry idempotently, and suppress duplicate delivery while preserving both general Type-C flags and Cmd1Completed.
• Reconcile command timeouts with the original caller output buffer. A conclusively successful CMD1/DATA1 result now returns Success with response bytes intact (including TFUq output); rejected, aborted, busy, malformed, and bus-error results retain their appropriate semantics.
• Reserve an independent 500 ms post-reset verification margin for TFUc without inflating unrelated command timeouts.

Confirmed evidence

Captured traces showed Cmd1Completed read and W1C-cleared inside a 100 ms future, then cancelled at a 99.21 ms span before publication. The later command-timeout reconciliation read CMD1=Success but mapped it to Timeout and discarded the output buffer. A separate TFUc run exhausted RESET_DELAY_MS + 100 ms just before the APP1 mode read.

This change is based directly on public v0.1.1 / stable-v0.1.y commit 95d54c3caf36ab30fa093b1f9bef236e9829c060.

Tests

• Focused interrupt read/clear, W1C cancellation/failure/retry/dedup, command timeout success/output/rejection/error, and TFUc boundary regressions
• cargo fmt --all --check
• cargo clippy
• cargo test (162 passed)
• cargo test --features embassy,log (178 passed)
• cargo hack --feature-powerset --exclude-features defmt test --all-targets
• cargo hack --feature-powerset check (16/16 combinations)

[Copilot]

🟡 Changes recommended

The timeout reconciliation path still collapses completed-but-non-success return codes into Timeout, and publish_interrupt can drop buffered flags if given an out-of-range port index.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR improves robustness around TPS6699x interrupt handling and command timeout recovery, targeting observed failure/cancellation edge cases and TFUc timing boundaries.

Changes:

• Split interrupt handling into a read/publish phase and a retryable W1C-clear phase by persisting pending clear masks in software state.
• Refine command timeout reconciliation so a command that actually completed successfully can return Success while preserving the caller’s output buffer.
• Add a dedicated TFUC_VERIFICATION_SLACK_MS margin to TFUc timeouts and cover it with a focused unit test.

File summaries

File	Description
src/command/mod.rs	Adjusts TFUc timeout calculation by adding a dedicated post-reset verification slack constant and test.
src/asynchronous/internal/mod.rs	Introduces durable pending_interrupt_clears state and new read_interrupt / clear_pending_interrupts APIs with updated tests.
src/asynchronous/embassy/mod.rs	Publishes interrupts prior to W1C clears, adds timeout reconciliation that can preserve outputs, and adds regression tests for cancellation/failure scenarios.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.