Update embedded-usb-pd - #130
Merged
RobertZ2011 merged 2 commits intoSep 4, 2026
Merged
Conversation
RobertZ2011
force-pushed
the
usci-versioning-fix
branch
from
September 4, 2026 19:16
d03bdc8 to
a064133
Compare
Cargo Vet Audit Passed
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The update introduces unpinned git dependencies and results in multiple sources of the same crates in the example lockfile, which risks non-reproducible builds and type/version incompatibilities.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates this crate (and the RT685 example) to use the UCSI v1.2 LPM module path from embedded-usb-pd, reflecting upstream API/feature changes.
Changes:
- Switch
lpmimports toembedded_usb_pd::ucsi::v1_2::lpmin driver/UCSI code. - Update
embedded-usb-pddependency configuration to enable theucsi-v1_2feature. - Refresh lockfiles to reflect new git revisions and updated transitive dependencies.
File summaries
| File | Description |
|---|---|
| src/odp/driver.rs | Updates UCSI LPM import path to v1.2 module. |
| src/asynchronous/embassy/ucsi.rs | Updates UCSI LPM import path to v1.2 module. |
| Cargo.toml | Adjusts embedded-usb-pd dependency to enable ucsi-v1_2. |
| Cargo.lock | Updates resolved dependency graph for the workspace. |
| examples/rt685s-evk/Cargo.toml | Adjusts embedded-usb-pd dependency to enable ucsi-v1_2 for the example. |
| examples/rt685s-evk/Cargo.lock | Updates resolved dependencies for the example. |
Review details
- Files reviewed: 4/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertZ2011
marked this pull request as ready for review
September 4, 2026 20:31
RobertZ2011
requested review from
felipebalbi,
jerrysxie,
makubacki,
tullom and
williampMSFT
September 4, 2026 20:31
williampMSFT
approved these changes
Sep 4, 2026
RobertZ2011
enabled auto-merge (squash)
September 4, 2026 21:47
asasine
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.