Fix data set button#2359
Conversation
jh-RLI
left a comment
jh-RLI
left a comment
There was a problem hiding this comment.
Please check the comments. There is one code issue and a link that was removed, please check what it links to and if we need that information.
| <a role="button" | ||
| class="btn btn-primary btn-sm" | ||
| href="{{ EXTERNAL_URLSgithub_openenergyplatform }}">Learn more</a> | ||
| href="{{ EXTERNAL_URLSgithub_openenergyplatform }}">Learn |
There was a problem hiding this comment.
This does not seem to be correct syntax:
EXTERNAL_URLSgithub_openenergyplatform -> EXTERNAL_URLS.github_openenergyplatform
You can check what happens once you click to related button in on your locally running OEP Website :)
| </div> | ||
| {# <div class="index-tile index-tile-colored index-tile-color-3">#} | ||
| {# <img src="{% static 'img/welcome/bundles.png' %}" alt="">#} | ||
| {# <a role="button" class="btn btn-primary" href="{{ EXTERNAL_URLS.github_openenergyplatform_oeplatform_issues_568 }}">Bundles</a>#} |
There was a problem hiding this comment.
What was this link, is it now missing ? Please check @tomi-rli
There was a problem hiding this comment.
The link pointed to issue #568, which is already closed. (on Dec 11, 2023). The entire block was commented out, so it was never visible or clickable. The active “Scenario Bundles” link is still present, so no functionality was removed.
jh-RLI
left a comment
jh-RLI
left a comment
There was a problem hiding this comment.
Thanks for the fixes - now it looks good. Will merge it now.
2 participants
Summary of the discussion
Describe the findings of the discussion in the issue or meeting.
Type of change (CHANGELOG.md)
Features
(#)
Changes
(#)
Bugs
(#)
Workflow checklist
Automation
Closes #2351
PR-Assignee
CONTRIBUTING.md
CHANGELOG.md
mkdocs
Reviewer
Reviewer Guidelines