Consolidate examples/, rename executables + library target#207
Merged
Conversation
Three long-standing paper cuts in one clean break: - demo/, txdemo/, examples/ collapse into a single examples/ tree, one directory per demo (rx, tx, streamtx, duplex, svctx, precoder, txpower, sense, common for the shared stream_stdin.h framing). - Executables get short lowercase names: rxdemo, txdemo, streamtx, duplex, svctx, precoder, txpower, sense. The old names overflowed the kernel's 15-char comm limit (WiFiDriverTxDemo = 16 chars), so `pkill -x WiFiDriverTxDemo` was a silent no-op — every truncated workaround form (WiFiDriverTxDem, StreamDuplexD, ...) in the test scripts is gone, including one pkill that never matched anything (WiFiDriverDe in eu_kernel_baseline.sh). - CMake library target WiFiDriver -> devourer (and project() likewise); the WiFiDriver.h header and class are unchanged, so source-level consumers are untouched. Link with `devourer`, find the archive at libdevourer.a. Selftest targets keep their names (ctest-only, never pkill targets). Stale build dirs keep old-name binaries around — do a clean build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three long-standing paper cuts, fixed in one clean break (no back-compat aliases):
1. One
examples/tree instead of three demo directories.demo/,txdemo/, andexamples/collapse into a singleexamples/, one directory per demo, withexamples/common/holding the sharedstream_stdin.hframing + its selftest. All moves aregit mv(history preserved).2. Short executable names. The old names overflowed the kernel's 15-char comm limit —
pkill -x WiFiDriverTxDemo(16 chars) was a silent no-op, and we've burned real debugging time on the truncated-comm workarounds scattered through the test scripts.WiFiDriverDemo/WiFiDriverTxDemorxdemo/txdemoStreamTxDemo/StreamDuplexDemostreamtx/duplexSvcTxDemo/PrecoderDemosvctx/precoderTxPowerStepDemo/WiFiSenseDemotxpower/senseEvery truncated workaround form (
WiFiDriverTxDem,StreamDuplexD,StreamTxDem, …) is gone, including one latent bug:eu_kernel_baseline.shranpkill -x WiFiDriverDe, which matched nothing, ever. Selftest targets keep their names (ctest-only, never pkill targets).3. Library target says what it is. CMake target +
project()renamedWiFiDriver→devourer; link withdevourer, archive islibdevourer.a. TheWiFiDriver.hheader andWiFiDriverclass are unchanged — source-level consumers don't change a line.All ~400 references across
tests/,tools/,docs/, README, CLAUDE.md, and the CI workflow are updated in this one commit.Validation
libdevourer.a;ctest10/10WiFiDriveroccurrences are the class/header onlybash -nall test scripts,py_compileall pythontxdemo→ kernel RX 7119/7500 hits ✓; devourer/devourerrxdemo+txdemo8000/8000 hits ✓ (8822CU→8812EU, ch36)Note for downstream
Old-name binaries linger in stale build dirs — do a clean build, or a running stale
WiFiDriverDemowill dodgepkill -x rxdemo.🤖 Generated with Claude Code