perf(agent): stop accumulating generator-tool preliminaryResults - #110
Open
LukasParke wants to merge 2 commits into
Open
perf(agent): stop accumulating generator-tool preliminaryResults#110LukasParke wants to merge 2 commits into
LukasParke wants to merge 2 commits into
Conversation
Yields are still broadcast live. The executor and ModelResult no longer copy every yield into a per-call array or onto the terminal tool.result event. Fixes DEV-817.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DEV-817.
Stop copying every generator-tool yield into a per-call array that lives until the call settles. Yields are still broadcast live via
onPreliminaryResult; the terminaltool.resultevent no longer carries the full history.This is the remaining isolate-memory landmine from the
@openrouter/agent0.9.0 review. PR #109 already covers opt-in replay compaction. This PR covers executor /ModelResultaccumulation.What
executeGeneratorToolno longer pushes validated yields intopreliminaryResults.ModelResultno longer accumulatespreliminaryResultsForCallor attaches it to the terminal result event.toolResultsToMap/summarizeToolExecutionsstop forwarding the unused array.Why
Fusion-style generator tools stream for minutes inside a 128MB Worker isolate. Broadcasting live is enough; retaining every yield until settle is O(total streamed bytes) and is the same failure mode the openrouter-web bun patch exists to stop.
The
getUsage()/getToolCalls()trim-unaware replay half of DEV-817 is already handled by PR #109 (initialResponsecache +getInitialResponse()).Test plan
pnpm lint/pnpm typecheckinpackages/agentpnpm testinpackages/agent: 96 files, 1153 tests