Skip to content

feat(badges): augment validateBadge payload for attendee-networking connect resolve#571

Open
smarcet wants to merge 1 commit into
mainfrom
feat/augment-validate-badge
Open

feat(badges): augment validateBadge payload for attendee-networking connect resolve#571
smarcet wants to merge 1 commit into
mainfrom
feat/augment-validate-badge

Conversation

@smarcet

@smarcet smarcet commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

https://app.clickup.com/t/9014802374/86bauc5hf

Extend GET /summits/{id}/badge/{badge}/validate so attendee-networking-api can resolve a scanned badge to a connection identity (SDS D26 / ftn-docsnsklz #40):

  • add ticket.owner.id (keys the member-less pre-account request, D27)
  • expand the nested ticket.owner.member {id, first_name, last_name, pic} (member.id is the D15 identity; member is absent for member-less attendees)

No auth change is needed: the auth.user middleware passes service tokens through (required-groups gate only user tokens), so a client-credentials service account holding the read scope already reaches the route.

Tests (OAuth2SummitApiTest): the member case asserts the expanded member object; the member-less case (D27) asserts the member object is absent while attendee id + email are present. InsertSummitTestData gains a member-less attendee with a badge to cover it.

@smarcet smarcet requested a review from romanetar July 9, 2026 18:36
…onnect resolve

Extend GET /summits/{id}/badge/{badge}/validate so attendee-networking-api can
resolve a scanned badge to a connection identity (SDS D26 / ftn-docsnsklz #40):

  - add ticket.owner.id (keys the member-less pre-account request, D27)
  - expand the nested ticket.owner.member {id, first_name, last_name, pic}
    (member.id is the D15 identity; member is absent for member-less attendees)

No auth change is needed: the auth.user middleware passes service tokens
through (required-groups gate only user tokens), so a client-credentials
service account holding the read scope already reaches the route.

Tests (OAuth2SummitApiTest): the member case asserts the expanded member
object; the member-less case (D27) asserts the member object is absent while
attendee id + email are present. InsertSummitTestData gains a member-less
attendee with a badge to cover it.
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-571/

This page is automatically updated on each push to this PR.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@smarcet, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 70d6a0d5-6bf1-4b01-b01a-553e62af3cc2

📥 Commits

Reviewing files that changed from the base of the PR and between 988a6d3 and 8af8b08.

📒 Files selected for processing (4)
  • .github/workflows/check-branch-name.yml
  • app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitApiController.php
  • tests/InsertSummitTestData.php
  • tests/oauth2/OAuth2SummitApiTest.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/augment-validate-badge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smarcet smarcet force-pushed the feat/augment-validate-badge branch from 7c93012 to 8af8b08 Compare July 9, 2026 18:38
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-571/

This page is automatically updated on each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant