Conversation
Clears the 14 x/crypto findings Aikido reports on this repo (the AIKIDO-2026-110xx group, all golang.org/x/crypto/ssh advisories fixed in 0.52.0). Raises the module's go directive 1.23.0 -> 1.25.0, which x/crypto v0.52.0 requires, so the README's stated requirement moves to Go 1.25 in the same commit. v0.52.0 rather than latest on purpose: v0.56.0+ would declare `go 1.26.0` and push the floor a further version for no additional fix. Consumers on default GOTOOLCHAIN are unaffected -- Go downloads the newer toolchain automatically. Consumers pinning GOTOOLCHAIN=local on Go < 1.25 will need to upgrade; verified that failure mode directly. Note this is hygiene, not an exposure fix. Nothing here imports x/crypto: it arrives indirectly via google.golang.org/api -> s2a-go, and the build graph contains only cryptobyte, chacha20, poly1305 and hkdf -- no ssh package, so none of the advisories were reachable. Because x/crypto is indirect, the declared version is only an MVS floor: consumers already resolve higher on their own (optable-sandbox builds this at v0.57.0). Verified: go build ./... and go vet ./protogen/... pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the 14 x/crypto findings Aikido reports on this repo — the
AIKIDO-2026-110xxgroup, allgolang.org/x/crypto/sshadvisories fixed in 0.52.0.The tradeoff, stated plainly
This raises the module's
godirective 1.23.0 → 1.25.0, because that's what x/crypto v0.52.0 requires. The README's stated requirement moves to Go 1.25 in the same commit so the docs don't contradict the manifest.v0.52.0 rather than latest is deliberate: v0.56.0+ declares
go 1.26.0and would push the floor another version for no additional fix here.Impact on consumers, verified rather than assumed:
GOTOOLCHAINGOTOOLCHAIN=localon Go < 1.25go.mod requires go >= 1.25.0 (running go 1.24.3; GOTOOLCHAIN=local)That second row is pinned CI, air-gapped builds, and distro packaging. This is a public module, so that's a real if narrow cost.
This is hygiene, not an exposure fix
Worth being explicit, so reviewers can weigh the above honestly:
google.golang.org/api→s2a-go.cryptobyte,chacha20,poly1305,hkdf— nosshpackage, so none of the 14 advisories were reachable.optable-sandboxdepends on this module and builds it at v0.57.0.So the benefit is a clean scanner board and a smaller future bump, not a closed vulnerability. Reasonable to reject on the grounds that the Go floor matters more than the finding.
Verification
go build ./...passesgo vet ./protogen/...passes