Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, it's only possible to build for macOS using
actwith-P macos-latest=-self-hosted. This limitation comes fromplutilnot being available on Linux.I have found a cross-platform, drop-in replacement for plutil. The downside: no binaries available, needs to be compiled from source.
So I just added these compilation steps to the script that sets up the environment. They are running conditionally, only when building on Linux for macOS and
plutilis not found in PATH.Now it can be tested by running
act -P macos-latest=catthehacker/ubuntu:act-22.04. Alternatively, you can specify your own Docker image withplutilbinary included, this would allow to skip the compilation and speed up the whole process.The resulting package needs to be compared against similar created with
-self-hostedoption, and if there are no significant differences, this can be merged.Type of change
Checklist: