Skip to content

Have the SciML linter allow non-yaml network formats#499

Open
BSnelling wants to merge 1 commit into
mainfrom
bes/equinox_format
Open

Have the SciML linter allow non-yaml network formats#499
BSnelling wants to merge 1 commit into
mainfrom
bes/equinox_format

Conversation

@BSnelling

Copy link
Copy Markdown
Collaborator

Such as "equinox": https://github.com/PEtab-dev/libpetab-python/pull/new/bes/equinox_format

For now I didn't include any validation of the network model file, just skip the NNModel construction and validation if the network format is not yaml.

@BSnelling BSnelling requested a review from a team as a code owner June 30, 2026 15:13
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.09%. Comparing base (e557e44) to head (0ea0187).

Files with missing lines Patch % Lines
petab/v2/extensions/sciml.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   75.12%   75.09%   -0.04%     
==========================================
  Files          64       64              
  Lines        7157     7160       +3     
  Branches     1265     1267       +2     
==========================================
  Hits         5377     5377              
- Misses       1290     1293       +3     
  Partials      490      490              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSnelling BSnelling force-pushed the bes/equinox_format branch from 03db394 to b7ccbda Compare July 1, 2026 09:41
@BSnelling BSnelling force-pushed the bes/equinox_format branch from b7ccbda to 0ea0187 Compare July 1, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants