fix: add missing STRING_TO functions to the standard library (1.0.x) - #1904
Open
ghaith wants to merge 1 commit into
Open
fix: add missing STRING_TO functions to the standard library (1.0.x)#1904ghaith wants to merge 1 commit into
ghaith wants to merge 1 commit into
Conversation
Problem: STRING_TO_* conversions exist only for LINT, DINT, REAL and LREAL, and the integer variants accept the longest valid prefix instead of rejecting malformed input. Solution: Move the lexer and the literal parsers into the plc_lexer and plc_parser crates so the standard library can reuse them, and add STRING_TO_* functions for BOOL, every integer and bit-string width, TIME, LTIME, DATE, DT and TOD that share one full-consumption parse rule. The date and time functions return the 64-bit nanosecond values used on this release line. Backport of #1884 and #1899. Refs: PRG-4659 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Build Artifacts🐧 Linux
From workflow run 🪟 Windows
From workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: STRING_TO_* conversions exist only for LINT, DINT, REAL and LREAL, and the integer variants accept the longest valid prefix instead of rejecting malformed input.
Solution: Move the lexer and the literal parsers into the plc_lexer and plc_parser crates so the standard library can reuse them, and add STRING_TO_* functions for BOOL, every integer and bit-string width, TIME, LTIME, DATE, DT and TOD that share one full-consumption parse rule. The date and time functions return the 64-bit nanosecond values used on this release line.
Backport of #1884 and #1899.
Refs: PRG-4659
🤖 Generated with Claude Code