Skip to content

Use ubuntu R for baseline - #6

Closed
fikovnik wants to merge 4 commits into
mainfrom
ci-baseline
Closed

fikovnik wants to merge 4 commits into
mainfrom
ci-baseline

Conversation

@fikovnik

Copy link
Copy Markdown
Member

No description provided.

@MatejKocourek

Copy link
Copy Markdown
Collaborator

Closing as superseded.

The baseline problem this PR targeted was solved differently on main: instead of switching to Ubuntu's r-base, the from-source vanilla R is now pinned via R_VERSION (Dockerfile.rcp-base) with its flags mirroring what rsh's build-gnur.sh uses for the RCP R, and Dockerfile.rcp-rsh asserts that the baseline and the vendored R are the same version so the two can't silently drift apart.

The incidental fixes here landed independently: ghcr.io-qualified DOCKER_IMAGE_ORG, the default all target, and moving the microbenchmark install off the rcp image into rcp-rsh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants