[Frontend] Added bug fix for autotune correctness issues. - #316
Open
KarthikL1729 wants to merge 1 commit into
Open
[Frontend] Added bug fix for autotune correctness issues.#316KarthikL1729 wants to merge 1 commit into
KarthikL1729 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobileNet-v2 and all other tests show correctness issues when run with the autotune codegen mapping strategy on tpuv3 (have not tried reproducing on other configs, but should be a problem there too) due to the tile size handling. This fix adds checks to prevent correctness issues. Tested with the docker container for v1.1.0 and MobileNet-v2 test on
systolic_ws_128x128_c1_simple_noc_tpuv3config.