Introduce $ sigil for value variables and reserve @ for node refs; update parser, writer, lexer, docs and templates - #11
Merged
TiernanDeFranco merged 1 commit intoMay 8, 2026
Conversation
TiernanDeFranco
deleted the
codex/create-scene-parser-with-@-node-refs-ptd262
branch
May 8, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
$for value vars and@for node refs/scene keys..scn/animation docs to use the new sigil conventions.Description
Dollartoken to the lexer and update the parser to treat$as the value-var sigil and@as node reference, including new parsing branches inparser.rsand variable collection changes incollect_var_entriesandparse_value.scene_doc.rs) to emit$for value vars and@for node refs, and adjust dedupe/var output accordingly.prepare/core.rs) to reference$rootwhere applicable when a missing root is detected.docs/*,perro_editor/res/*.scn,perro_editor/res/proj_manager.scn,scene node templates) to reflect the new sigils and examples forAnimationPlayer/AnimationTreebindings and scene parent/key usages.Testing
cargo test -p perro_scenewhich includes parser and scene_doc tests, and they passed after updating test expectations to the new syntax.cargo test -p perro_runtimeand they passed with the updated input/expectations.cargo testfor the modified workspace crates to verify integration; all affected tests succeeded.Codex Task