Conversation
Wunka
marked this pull request as draft
September 9, 2026 18:05
Contributor
|
good job with all this work |
Contributor
Author
|
As talked with quantum, while this should be looked at in general to find bugs, it's probably better to only merge this after 0.4.0 release to not get any bugs in the release |
IntegratedQuantum
requested changes
Sep 25, 2026
| #ifdef OPEN_GL | ||
| texCoords = vec2(inTexCoords.x, 1 - inTexCoords.y); | ||
| #else | ||
| texCoords = inTexCoords; |
Member
There was a problem hiding this comment.
Why are the vulkan and OpenGL versions differently here?
Contributor
Author
There was a problem hiding this comment.
this may actully be a general thing... I have removed the if. We will see how the vulkan code behaves once we are there
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready... first every thing has to be tested to still work. The nice thing is, for this can even a normal window be used, without
vulkanTestingMode, as this changes also in general how opengl things need to be renderd.c.glClipControl(c.GL_UPPER_LEFT, c.GL_ZERO_TO_ONE)does not apply this setting to everything. clipping for example still works on the old coordinate system.)