Open configuration dialog when username/profile is missing on Start - #91
Merged
Merged
Conversation
…profile The dialog was owned solely by TitlebarMenu's local state, so ControlPanel's existing pre-start validation could only toast an error, not surface a way to fix it. Lift the dialog into a context provided by MainFrame so both places can open it. Fixes #90 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
Nice work 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ControlPanel's pre-start checks already toasted an error when full name or profile data was missing, but never opened the Configuration dialog for the user to fix it - that dialog's open state lived only insideTitlebarMenu.useConfigurationDialogcontext, provided byMainFrame(wraps every route), and moved theConfigurationDialogmount there so it can be opened from anywhere in the tree.TitlebarMenu's menu item now opens the dialog through the shared context instead of owning its own local state.ControlPanel'sfullNameandhasProfileDatachecks now callopenConfigurationDialogas theironFail, alongside the existingtoast.error(...).Fixes #90
Test plan
pnpm exec tsc -p tsconfig.app.json --noEmit- cleanpnpm exec eslint src/renderer- cleanpnpm exec prettier --writeon touched files, diffed to confirm only intended changes