Skip to content

Feature/basic align - #9

Merged
laurejt merged 10 commits into
developfrom
feature/basic-align
Sep 3, 2026
Merged

laurejt merged 10 commits into
developfrom
feature/basic-align

Conversation

@laurejt

@laurejt laurejt commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Associated Issue(s): resolves #7, #8

Changes in this PR

  • Update handling of spans attribute for DocSpans to ensure immutability
  • Add library spans/match of some basic methods for span matching
  • Add SpanAlignment class
  • Add custom function types CheckSpanPair, ScoreSpanPair for readablility
  • Add library align with three alignment strategies

Reviewer Checklist

  • Unit tests run locally
  • Code documentation is legible and sufficient

@laurejt
laurejt requested a review from rlskoeser September 1, 2026 19:54
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f0f9709) to head (d15c79f).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop        #9    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         7     +4     
  Lines          258       545   +287     
  Branches        13        36    +23     
==========================================
+ Hits           258       545   +287     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rlskoeser rlskoeser left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks reasonable to me. Made some suggestions about places you could clarify some of the logic in comments/docs a bit

Comment thread src/spanerr/spans/match.py Outdated
Comment thread tests/test_spans/test_match.py Outdated
Comment thread src/spanerr/core.py Outdated
Comment thread src/spanerr/core.py Outdated
Comment thread src/spanerr/core.py Outdated
Comment thread src/spanerr/align.py Outdated
Comment thread src/spanerr/align.py
laurejt and others added 4 commits September 2, 2026 15:09
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
@laurejt
laurejt merged commit d005215 into develop Sep 3, 2026
18 checks passed
@laurejt
laurejt deleted the feature/basic-align branch September 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants