Feature/basic align - #9
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 7 +4
Lines 258 545 +287
Branches 13 36 +23
==========================================
+ Hits 258 545 +287 🚀 New features to boost your workflow:
|
rlskoeser
approved these changes
Sep 2, 2026
rlskoeser
left a comment
There was a problem hiding this comment.
Everything looks reasonable to me. Made some suggestions about places you could clarify some of the logic in comments/docs a bit
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): resolves #7, #8
Changes in this PR
DocSpansto ensure immutabilityspans/matchof some basic methods for span matchingSpanAlignmentclassCheckSpanPair,ScoreSpanPairfor readablilityalignwith three alignment strategiesReviewer Checklist