Add 26.1 to the version index - #54
Merged
Merged
Conversation
The 26.1 assets have shipped in the data submodule since 1.17.0, but the
version map in index.js was never updated, so mcAssets('26.1') returns
null even though data/26.1 is in the published package.
u9g
added a commit
to u9g/prismarine-viewer
that referenced
this pull request
Aug 22, 2026
1.18.0 is the first npm release shipping data/26.1. Exposing it through
mcAssets('26.1') additionally needs PrismarineJS/node-minecraft-assets#54,
so the effective minimum is the release that includes that fix.
Member
Author
|
/makerelease 1.19.0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 26.1 assets have shipped in the data submodule since 1.17.0 (PrismarineJS/minecraft-assets#50), but the version map in
index.jswas never updated, somcAssets('26.1')returnsnulleven thoughdata/26.1is in the published package (verified against the 1.18.0 npm tarball).Verified locally against the published 1.18.0 data:
mcAssets('26.1')resolves all 1168 blocks, and prismarine-viewer's atlas/blocksStates generation (PrismarineJS/prismarine-viewer#484) completes for 26.1 with no missing textures.Needed for PrismarineJS/prismarine-viewer#484 to work off a released minecraft-assets instead of locally generated data.