Skip to content

More straightforward way for compilation on MAC - #399

Open
ondrejkrejci wants to merge 6 commits into
mainfrom
mac-clang-installation
Open

More straightforward way for compilation on MAC#399
ondrejkrejci wants to merge 6 commits into
mainfrom
mac-clang-installation

Conversation

@ondrejkrejci

Copy link
Copy Markdown
Collaborator

Not for the automatic compilation, but at least the developers compilation, updated in installation wiki. Solves #398 .

@NikoOinonen

Copy link
Copy Markdown
Collaborator

Tests failing. Are you missing an import?

@ondrejkrejci

Copy link
Copy Markdown
Collaborator Author

Tests failing. Are you missing an import?

Yes, it was and still is. It is interesting - working well on my MAC, even gui and other stuff, but failing here. Need to look at it on my linux machine.

@ondrejkrejci
ondrejkrejci marked this pull request as draft August 24, 2026 12:04
@ondrejkrejci

Copy link
Copy Markdown
Collaborator Author

I have repaired it on linux, but it is now not working on MAC :-D

@ondrejkrejci
ondrejkrejci marked this pull request as ready for review August 27, 2026 08:37
@ondrejkrejci

Copy link
Copy Markdown
Collaborator Author

Hi @NikoOinonen and @yakutovicha - I have repaired it and it seems to be working.

@NikoOinonen

Copy link
Copy Markdown
Collaborator

@ondrejkrejci Can you also try the pip wheel build (once you have your Mac working again). It probably does not work with this right now since the setup process uses a different piece of code to run the make build here:

ppafm/setup.py

Lines 28 to 30 in f37a09b

def make(self):
os.system("make clean")
os.system("make all")

So try installing like this at the repo root:

python -m venv test_venv
source test_venv/bin/activate
pip install .[opencl]

And see if the examples work.

If not then you can probably just add the same M prefix to the make build at the location above for Mac.

@ondrejkrejci

Copy link
Copy Markdown
Collaborator Author

@ondrejkrejci Can you also try the pip wheel build (once you have your Mac working again). It probably does not work with this right now since the setup process uses a different piece of code to run the make build here:

ppafm/setup.py

Lines 28 to 30 in f37a09b

def make(self):
os.system("make clean")
os.system("make all")

So try installing like this at the repo root:

python -m venv test_venv
source test_venv/bin/activate
pip install .[opencl]

And see if the examples work.

If not then you can probably just add the same M prefix to the make build at the location above for Mac.

Thanks @NikoOinonen - good catch! I will try. I should have the computer tomorrow, but it will take me few days, to have everything settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants