You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
New default maxJobs values change queue worker lifecycle in all environments unless env is overridden, which can affect throughput and restart timing for BPMN and general queues.
Overview
Adds configurable Horizon worker job limits so BPMN and default queue supervisors can recycle workers after a set number of jobs.
config/horizon.php now sets maxJobs on supervisor-bpmn and supervisor-1 for production, local, and staging, driven by PM4_HORIZON_SUPERVISOR_BPMN_MAX_JOBS (default 10) and PM4_HORIZON_SUPERVISOR_1_MAX_JOBS (default 100). Setting either env var to 0 disables the limit. .env.example documents the new variables.
Unit/integration coverage in HorizonConfigTest asserts defaults, env overrides (including zero), and that queue:work --max-jobs processes a batch of jobs across multiple worker runs.
Reviewed by Cursor Bugbot for commit 0f19b1f. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
for QA (Alejandro) do some performance tests to make sure this did not impact scripts performance executing at least 30 scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Define a maxJobs and memory limit for BPMN and default
Solution
Current behavior is not possible to define this value and per default is 0 like
How to Test
Describe how to test that this solution works.
Related Tickets & Packages
Code Review Checklist