Skip to content

feat(assessment): Increase Dataset Row Fetch Limit - #1204

Merged
vprashrex merged 4 commits into
mainfrom
chore/bump-dataset-validation-limit
Sep 28, 2026
Merged

vprashrex merged 4 commits into
mainfrom
chore/bump-dataset-validation-limit

Conversation

@vprashrex

@vprashrex vprashrex commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

Closes #1206

Summary

Raise limit_rows max on GET /assessment/datasets/{id} from 100 to 2000. Updated docs to match.

Checklist

  • Ran fastapi run --reload app/main.py or docker compose up and tested.
  • Tests added/updated if applicable.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: ProjectTech4DevAI/kaapi-backend/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d1fbe382-c589-427a-9a9a-7bdcd7511620

📥 Commits

Reviewing files that changed from the base of the PR and between 14e4431 and 64970ef.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: ProjectTech4DevAI/kaapi-backend/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b8de66f4-5e15-4ab7-b379-f1bcc28c6520

📥 Commits

Reviewing files that changed from the base of the PR and between cf1cc2f and 071f1ad.

📒 Files selected for processing (2)
  • backend/app/api/docs/assessment/get_dataset.md
  • backend/app/api/routes/assessment/datasets.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The limit_rows maximum for GET /assessment/datasets/{id} increased from 100 to 2000. The endpoint documentation reflects the same range. The minimum and default remain unchanged.

Changes

Dataset Preview Limit

Layer / File(s) Summary
Update dataset preview limit
backend/app/api/routes/assessment/datasets.py, backend/app/api/docs/assessment/get_dataset.md
The endpoint accepts up to 2000 preview rows. The documentation now states the 1-2000 range. The minimum value and default remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 071f1

The endpoint now supports previews of up to 2,000 rows with matching documentation, and no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change satisfies issue #1206. backend/app/api/routes/assessment/datasets.py raises the get_dataset limit_rows maximum from 100 to 2000. backend/app/api/docs/assessment/get_dataset.md docum…
Out of Scope Changes check ✅ Passed The reviewed change is limited to the get_dataset endpoint limit and its corresponding API documentation. Both changes directly support issue #1206. The provided summary identifies no unrelated file…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Title check ✅ Passed The title clearly and concisely describes the main change: increasing the dataset row fetch limit for assessments.
Description check ✅ Passed The description directly explains the increase from 100 to 2000 and the corresponding documentation update.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title feat(Assessment): Dataset Update limit for preview rows to 2000 in get_dataset endpoint feat(assessment): Set dataset preview limit Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

OpenAPI changes   ⚪ No API surface changes

Note

This PR does not modify the API contract.

main ↔ d35ba923 · generated by oasdiff

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vprashrex vprashrex self-assigned this Sep 22, 2026
@Ayush8923

Ayush8923 commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

OpenAPI changes   🔴 1 breaking change

Caution

Downstream consumers may need an update before merging.

Breaking changes  ·  1
Method Path Change
🔴 PATCH /api/v1/projects/{project_id}/settings api path removed without deprecation
Full changelog  ·  2
Method Path Change
🔴 PATCH /api/v1/projects/{project_id}/settings api path removed without deprecation
🟢 — — a breaking change was detected but the version is still 0.5.0
main ↔ 1e05a0c0 · generated by oasdiff

@vprashrex just checking, can you please check this. is this expected?

@vprashrex vprashrex changed the title feat(assessment): Set dataset preview limit feat(assessment): Bump Dataset Rows Fetch Limit Sep 22, 2026
@vprashrex

vprashrex commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator Author

OpenAPI changes   🔴 1 breaking change

Caution

Downstream consumers may need an update before merging.

Breaking changes  ·  1

Method Path Change

🔴 PATCH /api/v1/projects/{project_id}/settings api path removed without deprecation

Full changelog  ·  2

Method Path Change

🔴 PATCH /api/v1/projects/{project_id}/settings api path removed without deprecation

🟢 — — a breaking change was detected but the version is still 0.5.0

main ↔ 1e05a0c0 · generated by oasdiff

@vprashrex just checking, can you please check this. is this expected?

The issue was that this feature branch wasn’t up to date with main, which already included the changes from PR #1129.

Because of this, oasdiff was comparing the latest main with the older feature branch and flagged the missing endpoint as a breaking change.

I have now updated the branch with the latest changes from main, and the oasdiff issue has been resolved.

@vprashrex vprashrex changed the title feat(assessment): Bump Dataset Rows Fetch Limit A cleaner version: feat(assessment): Increase Dataset Row Fetch Limit Sep 22, 2026
@vprashrex vprashrex changed the title A cleaner version: feat(assessment): Increase Dataset Row Fetch Limit feat(assessment): Increase Dataset Row Fetch Limit Sep 22, 2026
Query(
ge=1,
le=100,
le=2000,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fetching 2000 rows at once too much? how much load would this put on the system, and could it cause slowness in other APIs? have we checked all of these aspects?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this doesn't add extra load or affect other APIs, the file is already fetched in full regardless of the limit value, this param only controls how many rows get returned in this one preview response. It's isolated to this endpoint.

@vprashrex
vprashrex requested a review from Ayush8923 September 28, 2026 14:22
@vprashrex
vprashrex merged commit fe696fe into main Sep 28, 2026
6 checks passed
@vprashrex
vprashrex deleted the chore/bump-dataset-validation-limit branch September 28, 2026 16:11
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.7.0-main.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset: Increase limit_rows parameter

3 participants