feat(assessment): Increase Dataset Row Fetch Limit - #1204
Conversation
…t_dataset endpoint
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: ProjectTech4DevAI/kaapi-backend/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ProjectTech4DevAI/kaapi-backend/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesDataset Preview Limit
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The endpoint now supports previews of up to 2,000 rows with matching documentation, and no merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenAPI changes ⚪ No API surface changesNote This PR does not modify the API contract.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@vprashrex just checking, can you please check this. is this expected? |
The issue was that this feature branch wasn’t up to date with main, which already included the changes from PR #1129. Because of this, oasdiff was comparing the latest main with the older feature branch and flagged the missing endpoint as a breaking change. I have now updated the branch with the latest changes from main, and the oasdiff issue has been resolved. |
| Query( | ||
| ge=1, | ||
| le=100, | ||
| le=2000, |
There was a problem hiding this comment.
Is fetching 2000 rows at once too much? how much load would this put on the system, and could it cause slowness in other APIs? have we checked all of these aspects?
There was a problem hiding this comment.
No, this doesn't add extra load or affect other APIs, the file is already fetched in full regardless of the limit value, this param only controls how many rows get returned in this one preview response. It's isolated to this endpoint.
|
🎉 This PR is included in version 1.7.0-main.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Issue
Closes #1206
Summary
Raise
limit_rowsmax onGET /assessment/datasets/{id}from 100 to 2000. Updated docs to match.Checklist
fastapi run --reload app/main.pyordocker compose upand tested.