Skip to content

General update #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PumpkinSeed wants to merge 1 commit into
base: main
Choose a base branch
from
Open

General update #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions drivers/entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,32 @@
package drivers

import (
"log"
"fmt"

"github.com/PumpkinSeed/sqlfuzz/drivers/mysql"
"github.com/PumpkinSeed/sqlfuzz/drivers/postgres"
"github.com/PumpkinSeed/sqlfuzz/drivers/types"
)

// New creates a new driver instance based on the flags
func New(f types.Flags) types.Driver {
func New(f types.Flags) (types.Driver, error) {
switch f.Driver {
case "mysql":
return mysql.New(f)
return mysql.New(f), nil
case "postgres":
return postgres.New(f)
return postgres.New(f), nil
default:
log.Fatal("Driver not implemented")
return nil
return nil, fmt.Errorf("driver %q not implemented", f.Driver)
}
}

func NewTestable(f types.Flags) types.Testable {
func NewTestable(f types.Flags) (types.Testable, error) {
switch f.Driver {
case "mysql":
return mysql.New(f)
return mysql.New(f), nil
case "postgres":
return postgres.New(f)
return postgres.New(f), nil
default:
log.Fatal("Testable not implemented")
return nil
return nil, fmt.Errorf("testable %q not implemented", f.Driver)
}
}
13 changes: 7 additions & 6 deletions drivers/mysql/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
package mysql

import (
"fmt"
"strconv"
"strings"
)

func length(field string, t string) []int16 {
func length(field string, t string) ([]int16, error) {
field = strings.ToLower(field)
t = strings.ToLower(t)
if !(strings.Contains(field, "(") && strings.Contains(field, ")")) {
return nil
return nil, nil
}
str := strings.ReplaceAll(field, t, "")
str = strings.ReplaceAll(str, "(", "")
Expand All @@ -21,15 +22,15 @@ func length(field string, t string) []int16 {
for _, v := range p {
data, err := strconv.Atoi(v)
if err != nil {
panic(err)
return nil, fmt.Errorf("length: failed to parse %q: %w", v, err)
}
result = append(result, int16(data))
}
return result
return result, nil
}
v, err := strconv.Atoi(str)
if err != nil {
panic(err)
return nil, fmt.Errorf("length: failed to parse %q: %w", str, err)
}
return []int16{int16(v)}
return []int16{int16(v)}, nil
}
6 changes: 5 additions & 1 deletion drivers/mysql/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ func TestLength(t *testing.T) {
}

for _, scenario := range scenarios {
out := length(scenario.input, scenario.t)
out, err := length(scenario.input, scenario.t)
if err != nil {
t.Errorf("Unexpected error for input %q: %v", scenario.input, err)
continue
}
if !reflect.DeepEqual(scenario.output, out) {
t.Errorf("Output doesn't match with the scenario: %v, out: %v", scenario.output, out)
}
Expand Down
15 changes: 7 additions & 8 deletions drivers/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ import (

const (
MySQLDescribeTemplate = `select column_name, data_type, character_maximum_length, column_default, is_nullable,numeric_precision,numeric_scale,extra,column_key
from INFORMATION_SCHEMA.COLUMNS where table_name = '%s'`
from INFORMATION_SCHEMA.COLUMNS where table_name = ?`
MySQLDescribeTableQuery = "SHOW TABLES;"
mysqlFKQuery = `SELECT CONSTRAINT_NAME,TABLE_NAME,COLUMN_NAME,REFERENCED_TABLE_NAME,REFERENCED_COLUMN_NAME
from INFORMATION_SCHEMA.KEY_COLUMN_USAGE
where REFERENCED_TABLE_NAME <> 'NULL' and REFERENCED_COLUMN_NAME <> 'NULL' and TABLE_NAME = '%s'`
mysqlFKQuery = `SELECT CONSTRAINT_NAME,TABLE_NAME,COLUMN_NAME,REFERENCED_TABLE_NAME,REFERENCED_COLUMN_NAME
from INFORMATION_SCHEMA.KEY_COLUMN_USAGE
where REFERENCED_TABLE_NAME <> 'NULL' and REFERENCED_COLUMN_NAME <> 'NULL' and TABLE_NAME = ?`

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query filters out FK rows by comparing to the string literal 'NULL'. In MySQL INFORMATION_SCHEMA, these columns are NULL (not the string "NULL"), so IS NOT NULL is the clearer and idiomatic predicate (and avoids relying on NULL comparison semantics).

Suggested change
where REFERENCED_TABLE_NAME <> 'NULL' and REFERENCED_COLUMN_NAME <> 'NULL' and TABLE_NAME = ?`
where REFERENCED_TABLE_NAME IS NOT NULL and REFERENCED_COLUMN_NAME IS NOT NULL and TABLE_NAME = ?`

Copilot uses AI. Check for mistakes.
)

var (
Expand Down Expand Up @@ -178,12 +178,11 @@ func (m MySQL) MapField(descriptor types.FieldDescriptor) types.Field {
}

func (MySQL) Describe(table string, db *sql.DB) ([]types.FieldDescriptor, error) {
describeQuery := fmt.Sprintf(MySQLDescribeTemplate, table)
results, err := db.Query(describeQuery)
results, err := db.Query(MySQLDescribeTemplate, table)
if err != nil {
return nil, err
}
fkRows, err := db.Query(fmt.Sprintf(mysqlFKQuery, strings.ToLower(table)))
fkRows, err := db.Query(mysqlFKQuery, strings.ToLower(table))
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -214,7 +213,7 @@ func (m MySQL) MultiDescribe(tables []string, db *sql.DB) (tableToDescriptorMap
}

func (MySQL) GetLatestColumnValue(table, column string, db *sql.DB) (interface{}, error) {
query := fmt.Sprintf("select %v from %v order by %v desc limit 1", column, table, column)
query := fmt.Sprintf("select `%s` from `%s` order by `%s` desc limit 1", column, table, column)

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backtick-wrapping identifiers via fmt.Sprintf does not escape embedded backticks and still constructs SQL from raw strings. If table/column can include unexpected characters, this can break queries or allow injection. Prefer validating identifier names and/or using a dedicated identifier-quoting/escaping helper.

Copilot uses AI. Check for mistakes.
rows, err := db.Query(query)
if err != nil {
return nil, err
Expand Down
24 changes: 12 additions & 12 deletions drivers/postgres/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,26 +68,26 @@ const CreateTable = `CREATE TABLE IF NOT EXISTS %s (

const (
PSQLDescribeTemplate = `select column_name, data_type, character_maximum_length, column_default, is_nullable,numeric_precision,numeric_scale
from INFORMATION_SCHEMA.COLUMNS where table_name = '%s'`
from INFORMATION_SCHEMA.COLUMNS where table_name = $1`
PSQLConnectionTemplate = "host=%s port=%s user=%s password=%s dbname=%s sslmode=disable"
PSQLInsertTemplate = `INSERT INTO %s("%s") VALUES(%s)`
PSQLShowTablesQuery = "SELECT tablename FROM pg_catalog.pg_tables WHERE schemaname != 'pg_catalog' AND schemaname != 'information_schema';"
psqlForeignKeysQuery = `
psqlForeignKeysQuery = `
SELECT
tc.constraint_name,
tc.table_name,
kcu.column_name,
tc.constraint_name,
tc.table_name,
kcu.column_name,
ccu.table_name AS foreign_table_name,
ccu.column_name AS foreign_column_name
FROM
information_schema.table_constraints AS tc
ccu.column_name AS foreign_column_name
FROM
information_schema.table_constraints AS tc
JOIN information_schema.key_column_usage AS kcu
ON tc.constraint_name = kcu.constraint_name
AND tc.table_schema = kcu.table_schema
JOIN information_schema.constraint_column_usage AS ccu
ON ccu.constraint_name = tc.constraint_name
AND ccu.table_schema = tc.table_schema
WHERE tc.constraint_type = 'FOREIGN KEY' AND tc.table_name='%s'
WHERE tc.constraint_type = 'FOREIGN KEY' AND tc.table_name=$1
`
)

Expand Down Expand Up @@ -243,19 +243,19 @@ func (p Postgres) MultiDescribe(tables []string, db *sql.DB) (tableToDescriptorM
}

func (p Postgres) Describe(table string, db *sql.DB) ([]types.FieldDescriptor, error) {
results, err := db.Query(fmt.Sprintf(PSQLDescribeTemplate, strings.ToLower(table)))
results, err := db.Query(PSQLDescribeTemplate, strings.ToLower(table))
if err != nil {
return nil, err
}
fkResults, err := db.Query(fmt.Sprintf(psqlForeignKeysQuery, strings.ToLower(table)))
fkResults, err := db.Query(psqlForeignKeysQuery, strings.ToLower(table))
if err != nil {
return nil, err
}
return parsePostgresFields(results, fkResults)
}

func (p Postgres) GetLatestColumnValue(table, column string, db *sql.DB) (interface{}, error) {
query := fmt.Sprintf("select %s from %s order by %s desc limit 1", column, table, column)
query := fmt.Sprintf(`select "%s" from "%s" order by "%s" desc limit 1`, column, table, column)

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting identifiers with "%s" reduces some issues, but it does not escape embedded quotes and still builds SQL via string formatting. If table/column can contain unexpected characters (e.g., user-supplied table names or quoted identifiers), this can break queries or enable SQL injection. Prefer validating identifier names against an allowlist (e.g., [A-Za-z0-9_]+) and/or use a proper identifier-quoting helper that escapes quotes.

Copilot uses AI. Check for mistakes.
rows, err := db.Query(query)
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion drivers/utils/sqlcommons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func MultiDescribeHelper(tables []string, processedTables map[string]struct{}, d
continue
}
foreignTableName := field.ForeignKeyDescriptor.ForeignTableName
if _, ok := processedTables[foreignTableName]; ok && !knownTables[foreignTableName] {
if _, ok := processedTables[foreignTableName]; !ok && !knownTables[foreignTableName] {
newlyReferencedTables = append(newlyReferencedTables, foreignTableName)
knownTables[foreignTableName] = true
}
Expand Down
10 changes: 7 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@ go 1.14

require (
github.com/brianvoe/gofakeit/v5 v5.10.1
github.com/friendsofgo/errors v0.9.2 // indirect
github.com/go-sql-driver/mysql v1.5.0
github.com/gofrs/uuid v3.3.0+incompatible // indirect
github.com/lib/pq v1.9.0
github.com/rs/xid v1.2.1
github.com/volatiletech/inflect v0.0.1 // indirect
github.com/volatiletech/null v8.0.0+incompatible
)

require (
github.com/friendsofgo/errors v0.9.2 // indirect
github.com/gofrs/uuid v3.3.0+incompatible // indirect
github.com/volatiletech/inflect v0.0.1 // indirect
github.com/volatiletech/sqlboiler v3.7.1+incompatible // indirect
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
)
7 changes: 2 additions & 5 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
github.com/brianvoe/gofakeit v1.2.0 h1:GGbzCqQx9ync4ObAUhRa3F/M73eL9VZL3X09WoTwphM=
github.com/brianvoe/gofakeit v3.18.0+incompatible h1:wDOmHc9DLG4nRjUVVaxA+CEglKOW72Y5+4WNxUIkjM8=
github.com/brianvoe/gofakeit/v5 v5.10.1 h1:XamPDOAIoxcjEaeE+B4VvRsXk/g5OXm4gReH2fJCxNU=
github.com/brianvoe/gofakeit/v5 v5.10.1/go.mod h1:/ZENnKqX+XrN8SORLe/fu5lZDIo1tuPncWuRD+eyhSI=
github.com/friendsofgo/errors v0.9.2 h1:X6NYxef4efCBdwI7BgS820zFaN7Cphrmb+Pljdzjtgk=
github.com/friendsofgo/errors v0.9.2/go.mod h1:yCvFW5AkDIL9qn7suHVLiI/gH228n7PC4Pn44IGoTOI=
github.com/go-sql-driver/mysql v1.5.0 h1:ozyZYNQW3x3HtqT1jira07DN2PArx2v7/mN66gGcHOs=
github.com/go-sql-driver/mysql v1.5.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg=
github.com/gofrs/uuid v1.2.0 h1:coDhrjgyJaglxSjxuJdqQSSdUpG3w6p1OwN2od6frBU=
github.com/gofrs/uuid v3.3.0+incompatible h1:8K4tyRfvU1CYPgJsveYFQMhpFd/wXNM7iK6rR7UHz84=
github.com/gofrs/uuid v3.3.0+incompatible/go.mod h1:b2aQJv3Z4Fp6yNu3cdSllBxTCLRxnplIgP/c0N/04lM=
github.com/lib/pq v1.9.0 h1:L8nSXQQzAYByakOFMTwpjRoHsMJklur4Gi59b6VivR8=
Expand All @@ -17,8 +14,8 @@ github.com/volatiletech/inflect v0.0.1 h1:2a6FcMQyhmPZcLa+uet3VJ8gLn/9svWhJxJYwv
github.com/volatiletech/inflect v0.0.1/go.mod h1:IBti31tG6phkHitLlr5j7shC5SOo//x0AjDzaJU1PLA=
github.com/volatiletech/null v8.0.0+incompatible h1:7wP8m5d/gZ6kW/9GnrLtMCRre2dlEnaQ9Km5OXlK4zg=
github.com/volatiletech/null v8.0.0+incompatible/go.mod h1:0wD98JzdqB+rLyZ70fN05VDbXbafIb0KU0MdVhCzmOQ=
github.com/volatiletech/sqlboiler v1.0.0 h1:p0aCjD4tyDfjDjL6jakkfnrWWC4Z2wd1SNM7sS3rzAQ=
github.com/volatiletech/sqlboiler v3.7.1+incompatible h1:dm9/NjDskQVwAarmpeZ2UqLn1NKE8M3WHSHBS4jw2x8=
github.com/volatiletech/sqlboiler v3.7.1+incompatible/go.mod h1:jLfDkkHWPbS2cWRLkyC20vQWaIQsASEY7gM7zSo11Yw=
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
20 changes: 11 additions & 9 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,21 @@ import (
func main() {
f := flags.Get()
gofakeit.Seed(int64(f.Seed))
driver := drivers.New(f.Driver)
db := connector.Connection(driver, f)
driver, err := drivers.New(f.Driver)
if err != nil {
log.Fatal(err)
}
db, err := connector.Connection(driver, f)
if err != nil {
log.Fatal(err)
}
defer db.Close()

var tables []string
if f.Table == "" {
var err error
tables, err = driver.ShowTables(db)
if err != nil {
log.Print(err)
return
log.Fatal(err)
}
} else {
tables = []string{f.Table}
Expand All @@ -34,13 +38,11 @@ func main() {
f.Table = table
fields, err := driver.Describe(f.Table, db)
if err != nil {
log.Print(err.Error())
return
log.Fatal(err)
}
t := time.Now()
if err := fuzzer.Run(fields, f); err != nil {
log.Print(err.Error())
return
log.Fatal(err)
}
log.Printf("Fuzzing %s table taken: %v \n", table, time.Since(t))
}
Expand Down
64 changes: 50 additions & 14 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,18 @@ func TestFuzz(t *testing.T) {
f.Seed = 1

gofakeit.Seed(int64(f.Seed))
driver := drivers.New(f.Driver)
testable := drivers.NewTestable(f.Driver)
db := connector.Connection(driver, f)
driver, err := drivers.New(f.Driver)
if err != nil {
t.Fatal(err)
}
testable, err := drivers.NewTestable(f.Driver)
if err != nil {
t.Fatal(err)
}
db, err := connector.Connection(driver, f)
if err != nil {
t.Fatal(err)
}
defer db.Close()
if _, err := db.Exec(fmt.Sprintf("DROP TABLE IF EXISTS %s", f.Table)); err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -91,9 +100,18 @@ func TestFuzzPostgres(t *testing.T) {
f.Seed = 1

gofakeit.Seed(int64(f.Seed))
driver := drivers.New(f.Driver)
testable := drivers.NewTestable(f.Driver)
db := connector.Connection(driver, f)
driver, err := drivers.New(f.Driver)
if err != nil {
t.Fatal(err)
}
testable, err := drivers.NewTestable(f.Driver)
if err != nil {
t.Fatal(err)
}
db, err := connector.Connection(driver, f)
if err != nil {
t.Fatal(err)
}
defer db.Close()
if _, err := db.Exec(fmt.Sprintf("DROP TABLE IF EXISTS %s", f.Table)); err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -159,13 +177,22 @@ func TestMysqlMultiInsert(t *testing.T) {
f.Seed = 1

gofakeit.Seed(int64(f.Seed))
driver := drivers.New(f.Driver)
testable := drivers.NewTestable(f.Driver)
driver, err := drivers.New(f.Driver)
if err != nil {
t.Fatal(err)
}
testable, err := drivers.NewTestable(f.Driver)
if err != nil {
t.Fatal(err)
}
test, err := testable.GetTestCase("multi")
if err != nil {
t.Error(fmt.Sprintf("postgres : error fetching test case for multi. %v", err.Error()))
t.Fatal(fmt.Sprintf("mysql: error fetching test case for multi. %v", err.Error()))
}
db, err := connector.Connection(driver, f)
if err != nil {
t.Fatal(err)
}
db := connector.Connection(driver, f)
defer db.Close()
if _, err := db.Exec(fmt.Sprintf("DROP TABLE IF EXISTS %s", f.Table)); err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -201,13 +228,22 @@ func TestPostgresMultiInsert(t *testing.T) {
f.Seed = 1

gofakeit.Seed(int64(f.Seed))
driver := drivers.New(f.Driver)
testable := drivers.NewTestable(f.Driver)
driver, err := drivers.New(f.Driver)
if err != nil {
t.Fatal(err)
}
testable, err := drivers.NewTestable(f.Driver)
if err != nil {
t.Fatal(err)
}
test, err := testable.GetTestCase("multi")
if err != nil {
t.Error(fmt.Sprintf("postgres : error fetching test case for multi. %v", err.Error()))
t.Fatal(fmt.Sprintf("postgres: error fetching test case for multi. %v", err.Error()))
}
db, err := connector.Connection(driver, f)
if err != nil {
t.Fatal(err)
}
db := connector.Connection(driver, f)
defer db.Close()
if _, err := db.Exec(fmt.Sprintf("DROP TABLE IF EXISTS %s", f.Table)); err != nil {
t.Fatal(err)
Expand Down
Loading
Loading