Fix AOT DOM id-map rebind, isId(), getElementById disconnected guard - #35573
Merged
Conversation
…ard. loadHTML setAttribute id rebind now keys off receiver attrs and getElementById pairing instead of the global Attr cache; replaceChild clears detached link slots; map fallback rejects disconnected id-map hits while the single-slot cache stays authoritative for rebind temps lacking parent slots (#19870 / #29694 / #34821). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMAttr::isId()consults compile-time id-bearing flags before the user-function global path.replaceChildclears detached link slots; id map uses receiver attrs (not global Attr cache); map fallback returns null for disconnected nodes;setIdAttributeskips cache when id is already registered.setAttribute('id', …)rebind uses getElementById pairing + parsed id; single-slot cache stays authoritative (noisConnectedfilter on cache hits — compile-time temps lack parent slots).php-src:
ext/dom/attr.c(dom_attr_is_id),ext/dom/document.c(dom_get_element_by_id),ext/dom/node.c(detach clears links).Test plan
Closes #34821
Closes #29694
Closes #19870
Made with Cursor