DOM: scope getElementById LLVM cache by document (#20830) - #35578
Merged
Conversation
setIdAttribute on document A was leaking into getElementById on document B via the single-slot DomUserScriptElementCacheLlvm — importNode setIdAttribute survivor check failed AOT with setid_leak while VM/Zend returned ok. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getElementById()consultedDomUserScriptElementCacheLlvmby id string only; a priorsetIdAttribute()on document A madegetElementById('y')on document B return the wrong element (setid_leak) afterimportNode().lookupObject()now requiresGLOBAL_DOCto match the requesting document when a receiver is provided.DomImportNodeGetElementByIdReindex20830AotTestcoveringtest/repro/maintainer_gap_dom_importnode_getelementbyid_reindex.php.Root cause
php-src
ext/dom/node.c—setIdAttributedoes not surviveimportNode(only copyable libxml ID atypes do). VM path was correct; thin-AOT user-script cache ignored document scope.Test plan
Closes #20830
Made with Cursor