Self-host: dedupe mb_get_info spine requires (7965→7962/7962) - #35579
Merged
Conversation
…low-up). #35574 added JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime to the compile spine but left duplicate require_once lines (7965/7962). Remove the three extras so spine-count-sync reports 7962/7962 again. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_oncelines introduced by Self-host: sync mb_get_info JIT units into compile spine (7962/7962) #35574 (JitMbGetInfo.php,MbGetInfoJitHelper.php,MbGetInfoRuntime.php) incompiler_lib_spine_smoke/main.php.check-selfhost-spine-count-sync.phpis green again (was failing with duplicate-require errors after Self-host: sync mb_get_info JIT units into compile spine (7962/7962) #35574/Self-host: add mb_get_info JIT units to compile spine (#35570 follow-up) #35575).Follow-up to #35576 (zero-byte helper-runtime rejection). Lane overflow: north-star queue (#32122, #31968 children) fully closed; aot-smoke 8/8 and differential AOT 125/125 on master.
Test plan
Not run: full
make bootstrap-selfhost-lib-spine-smokerelink (dedupe-only; sidecar stamp still stale until a separate refresh).Made with Cursor