Self-host: dedupe mb_get_info spine requires (#35575 follow-up) - #35581
Merged
Conversation
Two racing spine-sync PRs left duplicate require_once for JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime — inflating the M2 counter to 7965/7962 and failing check-selfhost-spine-count-sync on ci-fast. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_onceforJitMbGetInfo.php,MbGetInfoJitHelper.php, andMbGetInfoRuntime.phpincompiler_lib_spine_smoke/main.phpafter parallel Self-host: sync mb_get_info JIT units into compile spine (7962/7962) #35574/Self-host: add mb_get_info JIT units to compile spine (#35570 follow-up) #35575 spine-sync PRs.lane overflow — no open north-star ticket; fixes
ci-fastspine-count-sync failure.Test plan
Not run:
north-star5-verify-fast(sidecar stamp drifts on spine entry edit — blobs unchanged, no restamp).Made with Cursor