AOT: mb_output_handler() runtime string via NestedJIT (#20014 leftover) - #35582
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/mb-output-handler-runtime-aot-20014
branch
from
August 28, 2026 02:24
5bdff76 to
2ef8ee4
Compare
5 tasks
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…35586) WAVE3_ROADMAP_SYNC_GATE and BootstrapSelfhostBundleTest expected 7962 while bootstrap-spine-count reports 7965 after #35582 mb_output_handler and spine inventory regen; refresh docs, inventory/profile tables, and test assertion. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 28, 2026
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…ts (#35582). (#35589) #35582/#35579 changed compiler_lib_spine_smoke/main.php but omitted the stamp refresh; check-selfhost-spine-sidecar-sync was red on master. Stamp-only follow-up, peer #35577. Verification: - php script/check-selfhost-spine-sidecar-sync.php → OK - ./script/aot-smoke.sh → 8 passed, 0 failed Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitMbOutputHandler+MbOutputHandlerJitHelper+MbOutputHandlerRuntimesomb_output_handler()accepts a runtime string under AOT (previouslyLogicException: requires compile-time string and int arguments).mb_http_output/mb_internal_encodingmodule globals (peerJitMbGetInfo/JitMbHttpOutput) and callsMbConvertEncodingJitHelper::convertArgv.MbstringAotFoldState).Closes leftover from #20014 (parent closed; runtime-string gap remained after #35570 landed
mb_get_info).php-src:
ext/mbstring/mbstring.c—PHP_FUNCTION(mb_output_handler)Test plan
Not covered:
ob_start('mb_output_handler')still requiresJitObStartcallback support (separate from this builtin lowering). Runtime status int variable has a separate compiler-path quirk — repro uses literal9like the compliance case.Made with Cursor