Verify King's Quest VI#640
Open
tomojira wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying King's Quest VI: Heir Today, Gone Tomorrow (1992) (Sierra On-Line)
This game is already in the verified dat, but double-checking it since it hasn't been done before.
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
No. I added installation instructions to reproduce the
RESOURCE.CFGfile, which is required to play the game; it can't be created later byINSTALL6.EXEbecause it will be missing a "minHunk" value which is apparently only added during installation, and the game will give an error if it isn't there.This
RESOURCE.CFGis slightly different than the current one, even though options are the same, so the copy in the DOSC and embedded data were both updated.Have any official patches been applied, if necessary?
No patches are mentioned on PCGamingWiki. This is likely the latest version, from the King's Quest Collection CDs.
Have digital versions (Steam, GOG) been checked for matching?
Yes, the GOG variant works. However, I had to edit its
RESOURCE.CFGto change its audio driver to Sound Blaster. Added a copy of it to the DOSC as well as embedded data, and instructions in the dat comment.Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, and it already does so with
RESOURCE.CFG.Can DoDAT build the game from the disc image?
Yes, but the Gabriel Knight Demo is required as well to provide its
VGA320.DRVfile, which fixes stuttering in the intro video. This is already explained in the dat comment, and a link is provided.https://archive.org/details/GabrielKnightSinsoftheFathers_1020
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
Yes.
Does the DOSZ run standalone?
Yes, with
RESOURCE.CFGincluded.For CD games, can the game be set up to run without a CD mounted?
No. The CD includes an audio track which plays during the game according to a quick search.
Can the game benefit from using CHDtoOGG?
Yes, and it already does so.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
The game has copy protection according to PCGamingWiki, but unclear if that applies to this CD version. TDC's notes mention cracking a file that doesn't seem to exist here.
Is the game running at the correct speed? Is CPU year specified?
The speed seems fine, but there is no CPU year specified. I added
cpu_year: 1992.Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Yes, and it's correctly using Old. The GOG variant was missing this so I added it there.
Does the game have General MIDI support?
Yes, but it wasn't in the DOSC yet. I added it.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I added it.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
There is a "Small" installation size, but it installs nothing at all besides
RESOURCE.CFG. The "Large" option addsINSTALL6.EXEfor changing settings.EDIT: I realized this explanation makes no sense, since
INSTALL6.EXEcan also be used from the CD. However, after testing the Small version, it is significantly slower, taking several more seconds for the game to start after hitting Play, and also taking more time when walking to a different area. So Large seems better here.Summary of changes
RESOURCE.CFGfile which is closer to what you get after installation, so minimal editing is needed. Updated embedded data and the copy in DOSCcpu_year: 1992