Draft 18 API update - #180
Conversation
|
Blame the heat for me not seeing #179 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a55fa7f13
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (param.first == static_cast<std::uint64_t>(quicr::messages::ParameterType::kNewGroupRequest)) { | ||
| s_attrs.new_group_request_id = true; |
There was a problem hiding this comment.
When this path matches an existing peer SUBSCRIBE after a local publish/announce appears, a peer may already have sent a NewGroupRequest value greater than 1 in parameters; this code only checks for the key and then sets new_group_request_id to true (i.e. 1), discarding the parsed ngr_id value above. That causes the subsequent subscribe processing to lose the actual group the peer requested, so late peer subscriptions can be forwarded without requesting the intended new group from the publisher.
Useful? React with 👍 / 👎.
1 participant
Quick API only change for draft-18