chore(apm): apm CLI を 0.24.1 に更新#396
Conversation
- mise.toml の github:microsoft/apm を 0.24.0 → 0.24.1 - mise install / mise lock で mise.lock を 0.24.1 の資産 URL・チェックサムに更新 (linux-x64 / macos-arm64) - apm install で apm.lock.yaml を再生成 (apm_version 0.24.1、依存 SHA は不変) - apm install / apm compile がエラーなく成功することを確認 - 前例: #390 (0.24.0 への更新) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHHZn4LccXneFtGUF81AWh
📝 WalkthroughWalkthroughThe APM lockfile was regenerated for version 0.24.1, adding a virtual review dependency, normalizing repository references and resolution metadata, recording MCP configuration provenance, and refreshing deployed file hashes. The mise tool pin was updated to match. ChangesAPM dependency refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
apm CLI を 0.24.0 → 0.24.1 に更新し、mise.toml/mise.lock を SSoT としたバージョン固定と、apm.lock.yaml の再生成結果をリポジトリに反映する PR です。
Changes:
mise.tomlの apm CLI バージョンを0.24.1に更新mise.lockの apm CLI アセット URL/チェックサムを0.24.1に更新（linux-x64 / macos-arm64）apm.lock.yamlを apm0.24.1基準で再生成（メタ情報更新に加え、一部構造/内容差分あり）
見てほしいところへの所見:
- Labels（
dependencies付与）の妥当性: 提示された差分情報からは PR ラベルを確認できないため判断できません。 - 「apm CLI のみ更新、依存 pin（apm.yml）は不変」方針: この PR の差分上は
apm.ymlが変更されておらず、方針どおりに見えます。ただしapm.lock.yamlに “並び順のみ” 以上の差分（MCP 設定周り）が出ている点は要確認です（指摘コメント参照）。
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mise.toml | mise 管理の apm CLI バージョンを 0.24.1 に更新 |
| mise.lock | apm CLI 0.24.1 の配布アセット（URL/チェックサム）へ更新 |
| apm.lock.yaml | apm 0.24.1 で lock を再生成し、メタ情報更新＋MCP 設定周りの差分を反映 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apm.lock.yaml (1)
410-413: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRestore the documented
chrome-devtoolsMCP configuration. The lockfile still resolveschrome-devtools-mcp, butmcp_servers/mcp_configsno longer enable it, soapm installships the dependency without the server. Regenerate withchrome-devtoolsincluded, or update the docs if this removal is intentional.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apm.lock.yaml` around lines 410 - 413, Update the mcp_servers configuration to include the documented chrome-devtools server, and ensure the corresponding mcp_configs entry is restored if required by the lockfile format. Regenerate the lockfile so chrome-devtools-mcp is enabled consistently with the server configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@apm.lock.yaml`:
- Around line 410-413: Update the mcp_servers configuration to include the
documented chrome-devtools server, and ensure the corresponding mcp_configs
entry is restored if required by the lockfile format. Regenerate the lockfile so
chrome-devtools-mcp is enabled consistently with the server configuration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 88672b99-e04c-48ab-85c1-8bea8b7e9219
⛔ Files ignored due to path filters (1)
mise.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
apm.lock.yamlmise.toml
初回コミットは `apm install` を `--trust-transitive-mcp` なしで実行したため、 mcp-toolkit 経由の推移的 MCP `chrome-devtools` が `mcp_servers` から外れていた (Copilot レビュー指摘)。#395 と同様に `apm install --trust-transitive-mcp` で 再生成し、chrome-devtools を lock へ復帰。 - apm.lock.yaml: mcp_servers に chrome-devtools を復帰、chrome-devtools 設定ブロックを再掲 - 0.24.1 の新フィールド mcp_config_provenance (chrome-devtools: chrome-devtools-mcp) を含む - repo_url の表記正規化 (ChromeDevTools → chromedevtools) は 0.24.1 の仕様 - apm compile 成功を再確認 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHHZn4LccXneFtGUF81AWh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apm.lock.yaml`:
- Around line 416-422: Update the chrome-devtools configuration’s args list to
include the npx --yes flag (-y) alongside chrome-devtools-mcp@1.5.0, ensuring
non-interactive launches proceed without an installation prompt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apm.lock.yaml`:
- Around line 416-422: Update the chrome-devtools configuration’s args list to
include the npx --yes flag (-y) alongside chrome-devtools-mcp@1.5.0, ensuring
non-interactive launches proceed without an installation prompt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 582f2f4a-fcc3-409a-a15e-dda200756d7c
📒 Files selected for processing (1)
apm.lock.yaml
🛑 Comments failed to post (1)
apm.lock.yaml (1)
416-422: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail # Inspect the relevant lockfile section and nearby entries. nl -ba apm.lock.yaml | sed -n '390,450p' # Search for other npx-based commands in the lockfile. rg -n "command: npx|args:" apm.lock.yamlRepository: ROhta/bingo
Length of output: 189
🏁 Script executed:
#!/bin/bash set -euo pipefail python3 - <<'PY' from pathlib import Path p = Path("apm.lock.yaml") lines = p.read_text().splitlines() for start, end in [(390, 450)]: for i in range(start-1, min(end, len(lines))): print(f"{i+1:4d}: {lines[i]}") PY echo echo "---- npx entries ----" python3 - <<'PY' from pathlib import Path lines = Path("apm.lock.yaml").read_text().splitlines() for i, line in enumerate(lines, 1): if "command: npx" in line or "args:" in line: print(f"{i:4d}: {line}") PYRepository: ROhta/bingo
Length of output: 4003
Add
-yto thechrome-devtoolsnpx args.Without it, a clean non-interactive launch can stop at the install prompt and never start the MCP server.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apm.lock.yaml` around lines 416 - 422, Update the chrome-devtools configuration’s args list to include the npx --yes flag (-y) alongside chrome-devtools-mcp@1.5.0, ensuring non-interactive launches proceed without an installation prompt.
期待する挙動・状態
mise.tomlを SSoT として、ローカル / CI とも 0.24.1 を消費する必要な依存関係
apm install --trust-transitive-mcp→apm compileを実行済みapm.yml) は不変。#main参照の resolved SHA も変化なし確認済み項目
mise install/mise lockでmise.lockを 0.24.1 の資産 URL・チェックサムへ更新 (linux-x64 / macos-arm64)apm install --trust-transitive-mcp成功 (apm.lock.yamlを apm_version 0.24.1 で再生成、依存 SHA は不変)apm compile成功 (Compilation completed successfully!)#main参照は同一コミットへ解決)mcp_serversに chrome-devtools / context7 / deepwiki / serena が全て残ることを確認apm.lock.yaml の差分について (0.24.1 の仕様変更)
apm CLI 0.24.1 への更新に伴い、依存 SHA の前進以外に以下の生成仕様変更が差分に含まれる (いずれも 0.24.1 の正当な挙動):
mcp_config_provenanceの追加 (各 MCP サーバーの配信元パッケージを記録)repo_url/resolved_byの表記正規化 (例:ChromeDevTools/chrome-devtools-mcp→chromedevtools/chrome-devtools-mcp)setup.instructions.md等) の再生成見てほしいところ
dependenciesを付与)apm.yml) に手を入れていない方針で問題ないか前例: #390 (apm CLI 0.24.0 への更新。
mise.toml/mise.lock/apm.lock.yamlを更新する同一パターン)🤖 Generated with Claude Code
https://claude.ai/code/session_01DHHZn4LccXneFtGUF81AWh