Skip to content

Fix the flaky demo e2e step that turned main red #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Randolin merged 1 commit into from
Aug 29, 2026
Merged

Fix the flaky demo e2e step that turned main red #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions e2e/run-e2e.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,14 @@ try {
// newcomer is shown before they commit to anything, and it never fetches.
step = 'demo-unconfigured';
await page.click('text=See a comparison first');
await page.waitForSelector('text=brave-azure-otter', { timeout: 30000 });
const demoBody = await page.textContent('body');
for (const expected of ['Overall alignment', 'Mutual desires', 'Fit, each way']) {
if (!demoBody.includes(expected)) fail(`demo is missing "${expected}" with no server`);
// Wait for the panels, not for the creature names. The names render as soon
// as the model resolves, but every panel is a lazily loaded component that
// arrives afterwards — snapshotting the body in between reads a page that is
// still filling in, which is a race that only shows up on a slow runner.
for (const expected of ['Overall alignment', 'Mutual desires', 'Fit, each way', 'In words']) {
await page.waitForSelector(`text=${expected}`, { timeout: 30000 });
}
const demoBody = await page.textContent('body');
// The dealbreaker alert and the mutual reveal are the two moments the demo
// exists to show; a demo that quietly lost them would still look fine.
if (!demoBody.includes('Alcohol')) fail('demo does not name the violated dealbreaker');
Expand Down