🎨 Palette: Add keyboard accessibility and action to user-pill - #129
Randomname653 wants to merge 1 commit into
Conversation
The `#user-pill` element had `cursor: pointer` in CSS, indicating it was interactive, but it lacked `role="button"`, `tabindex="0"`, a `data-on-keydown` handler, and an actual `data-action` click handler. Added the necessary attributes so it functions as a keyboard-accessible shortcut to Account Settings. Co-authored-by: Randomname653 <127677734+Randomname653@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Thanks - built into main in this codebase's idiom as 32cf008 (lands with the next push): the pill is a keyboard-reachable button to Settings > Account. One change against this branch: passing the pill to showView marked the pill active and left the sidebar unmarked, so every sidebar entry now names its view (data-view) and showView lights up the right one whoever opened the view. That also revived seven callers still using .sb-item[onclick*=...] selectors, and div buttons got a visible focus ring. |
Understood. Acknowledging that this work is now obsolete as it has been built into main with the mentioned improvements. |
… shows From PR #129 (Jules), built in this codebase's idiom: the pill in the top bar is a button (role, tabindex, keyActivate, aria-label) that opens the account pane. The PR passed the pill itself to showView, which marked it active and left the sidebar unmarked; every sidebar entry now names its view in data-view and showView lights the entry up whoever opened the view. That also revives seven callers that still looked for .sb-item[onclick*=…], a selector for handlers that have not existed since the data-action move. Div buttons had no keyboard focus ring at all: [role="button"]:focus-visible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
💡 What: Added missing keyboard accessibility attributes (
role="button",tabindex="0",title,aria-label, anddata-on-keydown="keyActivate") and bound the element todata-action="showSettingsAccount"for theuser-pillelement in the topbar.🎯 Why: The
user-pillvisually acts like a button (with hover styling and acursor: pointer), but previously had no semantic role, wasn't focusable, and lacked an actual click handler or keyboard action binding. Adding these allows it to function as a direct shortcut to the Account Settings pane, both for mouse and keyboard users.📸 Before/After:
♿ Accessibility:
role="button"to provide semantic meaning.tabindex="0"to make it focusable in the document flow.aria-label="Account settings"andtitle="Account settings"for screen reader and hover tooltip support.data-on-keydown="keyActivate"withdata-args-keydown='["$event","$el"]'to support keyboard activation (Enter/Space).PR created automatically by Jules for task 5600173601443770284 started by @Randomname653